From 41d550d135d186dd97343467f280b8bfb1a6fa61 Mon Sep 17 00:00:00 2001 From: Florian Zschocke Date: Wed, 26 Oct 2022 18:03:40 +0200 Subject: ci: Update action versions in push build workflow The workflow runs started issuing warnings because NodeJS 12 was deprecated. Actions need to get updated to newer versions that use NodeJS 16. This commit updates the `actions/checkout` and the `actions/setup-java` actions to the latest version in the workflow that builds on every push. The new setup-java action requires the distribution to be specified, since multiple JDK distributions are supported now. We chose Eclipse's Temurin here which is the successor to AdoptOpenJDK, which we use for development. --- .github/workflows/ci-build.yml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-build.yml b/.github/workflows/ci-build.yml index 2bbd2af5..eab73378 100644 --- a/.github/workflows/ci-build.yml +++ b/.github/workflows/ci-build.yml @@ -20,14 +20,15 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v3 with: submodules: true - name: Setup Java ${{ matrix.java-version }} - uses: actions/setup-java@v1 + uses: actions/setup-java@v3 with: java-version: ${{ matrix.java-version }} + distribution: 'temurin' - name: Setup Moxie run: | @@ -53,14 +54,15 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v1 + uses: actions/checkout@v3 with: submodules: true - name: Setup Java ${{ matrix.java-version }} - uses: actions/setup-java@v1 + uses: actions/setup-java@v3 with: java-version: ${{ matrix.java-version }} + distribution: 'temurin' - name: Report Java version run: | -- cgit v1.2.3 From b9cf503e7873e3a18fbf2a05b0b59ea95d866048 Mon Sep 17 00:00:00 2001 From: Florian Zschocke Date: Wed, 26 Oct 2022 19:13:08 +0200 Subject: ci: Update action versions in nightly build workflow Versions are updated for various actions that have a new version which uses NodeJS 16. One action has no updated version available yet: `e1himself/goss-installation-action` But an issue exists mentioning that it needs an update. --- .github/workflows/nightly-build.yml | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 2dec7ff2..49a38bf2 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -30,7 +30,7 @@ jobs: steps: - name: Cache marker for latest commit - uses: actions/cache@v2 + uses: actions/cache@v3 id: cache-sha with: key: sha-${{ github.sha }} @@ -68,14 +68,15 @@ jobs: steps: - name: Checkout Gitblit - uses: actions/checkout@v1 + uses: actions/checkout@v3 with: submodules: true - name: Setup Java 8 - uses: actions/setup-java@v1 + uses: actions/setup-java@v3 with: java-version: 8 + distribution: 'temurin' - name: Report Java version run: | @@ -87,7 +88,7 @@ jobs: - name: Save built Gitblit package if: ${{ github.ref == 'refs/heads/master' || github.ref == 'refs/heads/develop' }} - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: gitblit-nightly path: build/target/gitblit-*-SNAPSHOT.tar.gz @@ -131,21 +132,21 @@ jobs: steps: - name: Checkout gitblit-docker - uses: actions/checkout@v1 + uses: actions/checkout@v3 with: repository: ${{ env.GH_ORG }}/gitblit-docker ref: master fetch-depth: 2 - name: Download Gitblit nightly build - uses: actions/download-artifact@v2 + uses: actions/download-artifact@v3 id: get-gb with: name: gitblit-nightly path: ../gitblit-docker # Delete the artifact unless this is the official Gitblit repo - - uses: geekyeggo/delete-artifact@v1 + - uses: geekyeggo/delete-artifact@v2 if: ${{ github.repository != 'gitblit/gitblit' }} with: name: gitblit-nightly @@ -171,13 +172,13 @@ jobs: echo "BUILD_DATE=$(date +%Y-%m-%dT%H:%M:%S)" >> "${GITHUB_ENV}" - name: Login to Docker Hub - uses: docker/login-action@v1 + uses: docker/login-action@v2 with: username: ${{ secrets.DOCKERHUB_GB_USER }} password: ${{ secrets.DOCKERHUB_GB_TOKEN }} - name: Build snapshot docker image - uses: docker/build-push-action@v2 + uses: docker/build-push-action@v3 with: file: ../gitblit-docker/generate/Dockerfile context: ../gitblit-docker @@ -226,7 +227,7 @@ jobs: dgoss run -p 8080:8080 -p 8443:8443 --tmpfs /var/opt/gitblit/temp gitblit/gitblit:nightly - name: Push docker image to registry - uses: docker/build-push-action@v2 + uses: docker/build-push-action@v3 with: file: ../gitblit-docker/generate/Dockerfile context: ../gitblit-docker -- cgit v1.2.3 From c950ce3d9b186ff7812a661b6afb3be34d26dd4d Mon Sep 17 00:00:00 2001 From: Florian Zschocke Date: Wed, 26 Oct 2022 19:27:32 +0200 Subject: ci: Replace set-output command with echo to GITHUB_OUTPUT The `set-output` command was deprecated. The new way to set an output parameter for a step is to echo to the file stored in `$GITHUB_OUTPUT` --- .github/workflows/nightly-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/nightly-build.yml b/.github/workflows/nightly-build.yml index 49a38bf2..38a1ff17 100644 --- a/.github/workflows/nightly-build.yml +++ b/.github/workflows/nightly-build.yml @@ -111,7 +111,7 @@ jobs: id: check-dh-login run: | if [[ -n "${{secrets.DOCKERHUB_GB_TOKEN}}" && -n "${{secrets.DOCKERHUB_GB_USER}}" ]] ; then - echo "::set-output name=secrets_present::true" + echo "secrets_present=true" >> $GITHUB_OUTPUT else echo "No Docker Hub login data found. Skipping Docker." fi @@ -163,7 +163,7 @@ jobs: gbver=${gbver##*gitblit-} echo "Version detected: $gbver" echo "GITBLIT_VERSION=$gbver" >> "${GITHUB_ENV}" - echo "::set-output name=gb-version::$gbver" + echo "gb-version=$gbver" >> $GITHUB_OUTPUT - name: Generate Dockerfile for snapshot image working-directory: ../gitblit-docker -- cgit v1.2.3