From bb8d1a33e365df7a48dfb4238867b31436f600ca Mon Sep 17 00:00:00 2001
From: Martin Spielmann <martin.spielmann@pingunaut.com>
Date: Tue, 8 Dec 2015 14:30:11 +0100
Subject: Remove empty catch blocks to stop swallowing exceptions. #498

---
 .../java/com/gitblit/client/GitblitClient.java     | 43 ++++++----------------
 1 file changed, 12 insertions(+), 31 deletions(-)

diff --git a/src/main/java/com/gitblit/client/GitblitClient.java b/src/main/java/com/gitblit/client/GitblitClient.java
index f5bba1ad..aecf81f6 100644
--- a/src/main/java/com/gitblit/client/GitblitClient.java
+++ b/src/main/java/com/gitblit/client/GitblitClient.java
@@ -33,10 +33,6 @@ import com.gitblit.Constants.AccessRestrictionType;
 import com.gitblit.Constants.AuthorizationControl;
 import com.gitblit.Constants.PermissionType;
 import com.gitblit.Constants.RegistrantType;
-import com.gitblit.GitBlitException.ForbiddenException;
-import com.gitblit.GitBlitException.NotAllowedException;
-import com.gitblit.GitBlitException.UnauthorizedException;
-import com.gitblit.GitBlitException.UnknownRequestException;
 import com.gitblit.Keys;
 import com.gitblit.models.FederationModel;
 import com.gitblit.models.FeedEntryModel;
@@ -119,34 +115,19 @@ public class GitblitClient implements Serializable {
 		refreshRepositories();
 		refreshSubscribedFeeds(0);
 
-		try {
-			// credentials may not have administrator access
-			// or server may have disabled rpc management
-			refreshUsers();
-			if (protocolVersion > 1) {
-				refreshTeams();
-			}
-			allowManagement = true;
-		} catch (UnauthorizedException e) {
-		} catch (ForbiddenException e) {
-		} catch (NotAllowedException e) {
-		} catch (UnknownRequestException e) {
-		} catch (IOException e) {
-			e.printStackTrace();
-		}
-
-		try {
-			// credentials may not have administrator access
-			// or server may have disabled rpc administration
-			refreshStatus();
-			allowAdministration = true;
-		} catch (UnauthorizedException e) {
-		} catch (ForbiddenException e) {
-		} catch (NotAllowedException e) {
-		} catch (UnknownRequestException e) {
-		} catch (IOException e) {
-			e.printStackTrace();
+		// credentials may not have administrator access
+		// or server may have disabled rpc management
+		refreshUsers();
+		if (protocolVersion > 1) {
+			refreshTeams();
 		}
+		allowManagement = true;
+
+		// credentials may not have administrator access
+		// or server may have disabled rpc administration
+		refreshStatus();
+		allowAdministration = true;
+
 	}
 
 	public int getProtocolVersion() {
-- 
cgit v1.2.3