From 23e08cdfd5f61e06f584c7fce4e765dd8b6e6643 Mon Sep 17 00:00:00 2001 From: James Moger Date: Mon, 25 Nov 2013 10:07:46 -0500 Subject: Refactor managers and authentication for federation Change-Id: I5ff18b2768095fb14e7fbece2e756115829abbde --- .../com/gitblit/manager/AuthenticationManager.java | 30 +--------------------- 1 file changed, 1 insertion(+), 29 deletions(-) (limited to 'src/main/java/com/gitblit/manager/AuthenticationManager.java') diff --git a/src/main/java/com/gitblit/manager/AuthenticationManager.java b/src/main/java/com/gitblit/manager/AuthenticationManager.java index 6e541c45..8c66ce59 100644 --- a/src/main/java/com/gitblit/manager/AuthenticationManager.java +++ b/src/main/java/com/gitblit/manager/AuthenticationManager.java @@ -183,7 +183,7 @@ public class AuthenticationManager implements IAuthenticationManager { if (principal != null) { String username = principal.getName(); if (!StringUtils.isEmpty(username)) { - boolean internalAccount = isInternalAccount(username); + boolean internalAccount = userManager.isInternalAccount(username); UserModel user = userManager.getUserModel(username); if (user != null) { // existing user @@ -322,15 +322,6 @@ public class AuthenticationManager implements IAuthenticationManager { // can not authenticate empty password return null; } - // check to see if this is the federation user -// if (canFederate()) { -// if (usernameDecoded.equalsIgnoreCase(Constants.FEDERATION_USER)) { -// List tokens = getFederationTokens(); -// if (tokens.contains(pw)) { -// return getFederationUser(); -// } -// } -// } // try local authentication UserModel user = userManager.getUserModel(usernameDecoded); @@ -489,23 +480,4 @@ public class AuthenticationManager implements IAuthenticationManager { } return AuthenticationProvider.NULL_PROVIDER; } - - /** - * Returns true if the username represents an internal account - * - * @param username - * @return true if the specified username represents an internal account - */ - protected boolean isInternalAccount(String username) { - return !StringUtils.isEmpty(username) - && (username.equalsIgnoreCase(Constants.FEDERATION_USER) - || username.equalsIgnoreCase(UserModel.ANONYMOUS.username)); - } - -// protected UserModel getFederationUser() { -// // the federation user is an administrator -// UserModel federationUser = new UserModel(Constants.FEDERATION_USER); -// federationUser.canAdmin = true; -// return federationUser; -// } } -- cgit v1.2.3