From 1b34b05f5b8d2d0fd51819b286e22d7ddd27cb27 Mon Sep 17 00:00:00 2001 From: James Moger Date: Fri, 16 May 2014 13:50:59 -0400 Subject: Embrace @Inject for Managers, Servlets, and Filters --- src/main/java/com/gitblit/servlet/GitServlet.java | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'src/main/java/com/gitblit/servlet/GitServlet.java') diff --git a/src/main/java/com/gitblit/servlet/GitServlet.java b/src/main/java/com/gitblit/servlet/GitServlet.java index 93fe31d0..e9c5242f 100644 --- a/src/main/java/com/gitblit/servlet/GitServlet.java +++ b/src/main/java/com/gitblit/servlet/GitServlet.java @@ -20,6 +20,8 @@ import static javax.servlet.http.HttpServletResponse.SC_NOT_FOUND; import java.io.IOException; import java.util.Enumeration; +import javax.inject.Inject; +import javax.inject.Singleton; import javax.servlet.FilterChain; import javax.servlet.FilterConfig; import javax.servlet.ServletConfig; @@ -33,14 +35,11 @@ import javax.servlet.http.HttpServletResponse; import org.eclipse.jgit.http.server.GitFilter; -import com.gitblit.dagger.DaggerContext; import com.gitblit.git.GitblitReceivePackFactory; import com.gitblit.git.GitblitUploadPackFactory; import com.gitblit.git.RepositoryResolver; import com.gitblit.manager.IGitblit; -import dagger.ObjectGraph; - /** * The GitServlet provides http/https access to Git repositories. * Access to this servlet is protected by the GitFilter. @@ -48,24 +47,23 @@ import dagger.ObjectGraph; * @author James Moger * */ +@Singleton public class GitServlet extends HttpServlet { private static final long serialVersionUID = 1L; private final GitFilter gitFilter; - public GitServlet() { + @Inject + public GitServlet(IGitblit gitblit) { gitFilter = new GitFilter(); + gitFilter.setRepositoryResolver(new RepositoryResolver(gitblit)); + gitFilter.setUploadPackFactory(new GitblitUploadPackFactory(gitblit)); + gitFilter.setReceivePackFactory(new GitblitReceivePackFactory(gitblit)); } @Override public void init(final ServletConfig config) throws ServletException { - ServletContext context = config.getServletContext(); - ObjectGraph dagger = (ObjectGraph) context.getAttribute(DaggerContext.INJECTOR_NAME); - IGitblit gitblit = dagger.get(IGitblit.class); - gitFilter.setRepositoryResolver(new RepositoryResolver(gitblit)); - gitFilter.setUploadPackFactory(new GitblitUploadPackFactory(gitblit)); - gitFilter.setReceivePackFactory(new GitblitReceivePackFactory(gitblit)); gitFilter.init(new FilterConfig() { @Override -- cgit v1.2.3