From 4aeec822d0fe9306c4ca64f1a1d9683f77684198 Mon Sep 17 00:00:00 2001 From: James Moger Date: Thu, 28 Mar 2013 16:58:40 -0400 Subject: Do not queue emails with no recipients (issue 200) --- src/main/java/com/gitblit/GitBlit.java | 8 ++++++++ 1 file changed, 8 insertions(+) (limited to 'src/main/java') diff --git a/src/main/java/com/gitblit/GitBlit.java b/src/main/java/com/gitblit/GitBlit.java index 2361a6e4..b8daa06c 100644 --- a/src/main/java/com/gitblit/GitBlit.java +++ b/src/main/java/com/gitblit/GitBlit.java @@ -2903,6 +2903,10 @@ public class GitBlit implements ServletContextListener { * @param toAddresses */ public void sendMail(String subject, String message, String... toAddresses) { + if (toAddresses == null || toAddresses.length == 0) { + logger.debug(MessageFormat.format("Dropping message {0} because there are no recipients", subject)); + return; + } try { Message mail = mailExecutor.createMessage(toAddresses); if (mail != null) { @@ -2934,6 +2938,10 @@ public class GitBlit implements ServletContextListener { * @param toAddresses */ public void sendHtmlMail(String subject, String message, String... toAddresses) { + if (toAddresses == null || toAddresses.length == 0) { + logger.debug(MessageFormat.format("Dropping message {0} because there are no recipients", subject)); + return; + } try { Message mail = mailExecutor.createMessage(toAddresses); if (mail != null) { -- cgit v1.2.3