aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGusted <williamzijl7@hotmail.com>2022-10-16 16:56:58 +0000
committerGitHub <noreply@github.com>2022-10-17 00:56:58 +0800
commit3f032759ed40c8815e301cf5cc9f64f04864f731 (patch)
tree8fab2c1a9dd4db35f653d7b802f5008a581f1262
parentf48fda8eefa4d47e335f01ac92366b9373950e0e (diff)
downloadgitea-3f032759ed40c8815e301cf5cc9f64f04864f731.tar.gz
gitea-3f032759ed40c8815e301cf5cc9f64f04864f731.zip
Return 404 when user is not found on avatar (#21476) (#21477)
- Backport #21476 - Instead of returning a 500 Internal Server when the user wasn't found, return 404 Not found.
-rw-r--r--routers/web/user/avatar.go4
1 files changed, 4 insertions, 0 deletions
diff --git a/routers/web/user/avatar.go b/routers/web/user/avatar.go
index 53a603fab0..05896299d2 100644
--- a/routers/web/user/avatar.go
+++ b/routers/web/user/avatar.go
@@ -31,6 +31,10 @@ func AvatarByUserName(ctx *context.Context) {
if strings.ToLower(userName) != "ghost" {
var err error
if user, err = user_model.GetUserByName(ctx, userName); err != nil {
+ if user_model.IsErrUserNotExist(err) {
+ ctx.NotFound("GetUserByName", err)
+ return
+ }
ctx.ServerError("Invalid user: "+userName, err)
return
}