diff options
| author | Gusted <williamzijl7@hotmail.com> | 2021-12-26 14:56:14 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-26 22:56:14 +0800 |
| commit | a2afd38f25032c996499ce047fd51789f4fba861 (patch) | |
| tree | c0eec8ced89f52171e21ba2c56dcaa6e880c70b6 | |
| parent | 4da2eabd7f711fd4aaf3345ed180a850859cebbe (diff) | |
| download | gitea-a2afd38f25032c996499ce047fd51789f4fba861.tar.gz gitea-a2afd38f25032c996499ce047fd51789f4fba861.zip | |
Enable linter [rule.modifies-value-receiver] and refactor RoleDescriptor (#18093)
| -rw-r--r-- | .revive.toml | 1 | ||||
| -rw-r--r-- | models/issue_comment.go | 3 |
2 files changed, 2 insertions, 2 deletions
diff --git a/.revive.toml b/.revive.toml index 499a4051a1..54f075f84f 100644 --- a/.revive.toml +++ b/.revive.toml @@ -24,3 +24,4 @@ warningCode = 1 [rule.indent-error-flow] [rule.errorf] [rule.duplicated-imports] +[rule.modifies-value-receiver] diff --git a/models/issue_comment.go b/models/issue_comment.go index e54d41bf0d..360a212a23 100644 --- a/models/issue_comment.go +++ b/models/issue_comment.go @@ -123,8 +123,7 @@ const ( // WithRole enable a specific tag on the RoleDescriptor. func (rd RoleDescriptor) WithRole(role RoleDescriptor) RoleDescriptor { - rd |= (1 << role) - return rd + return rd | (1 << role) } func stringToRoleDescriptor(role string) RoleDescriptor { |