diff options
author | Forest Johnson <forest.n.johnson@gmail.com> | 2021-09-27 08:00:54 -0500 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-09-27 14:00:54 +0100 |
commit | 868e937a5354d4d8d9fd754fc80be26a5f345ba6 (patch) | |
tree | df027b7f9b37afc9412c17d895e98e7266951db5 | |
parent | 920608e592549fa18991758eb2aa1761cfb8c6ba (diff) | |
download | gitea-868e937a5354d4d8d9fd754fc80be26a5f345ba6.tar.gz gitea-868e937a5354d4d8d9fd754fc80be26a5f345ba6.zip |
docs: explain where are settings for release files (#17161)
Just a tiny change to save someone some time while reading the docs. I got lost in the angular code and npm packages trying to reverse engineer it and figure out what setting controlled this file limit:
![image](https://user-images.githubusercontent.com/7119703/134829716-8f587878-21a3-413b-ba1e-c2bbe9391ad2.png)
Eventually I tracked it down from
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/options/locale/locale_en-US.ini#L2776
to
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/templates/repo/upload.tmpl#L11
to
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/web_src/js/index.js#L1043
to
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/web_src/js/features/dropzone.js#L3
to
https://www.npmjs.com/package/dropzone
and then I realized I can't read :sweat_smile:, back to
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/templates/repo/upload.tmpl#L8
and quickly solved it from there!!
https://github.com/go-gitea/gitea/blob/b74a0f9060d5fda341f5554ef529a2006308c6ab/modules/upload/upload.go#L81
Yes I know this long path was 90% me failing to read code properly and going on a red herring journey... but point is we should not have to do this in the first place to know how to configure this file upload form :pleading_face: :point_right: :point_left:
-rw-r--r-- | docs/content/doc/advanced/config-cheat-sheet.en-us.md | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/docs/content/doc/advanced/config-cheat-sheet.en-us.md b/docs/content/doc/advanced/config-cheat-sheet.en-us.md index 6c2c92b814..7929f35c57 100644 --- a/docs/content/doc/advanced/config-cheat-sheet.en-us.md +++ b/docs/content/doc/advanced/config-cheat-sheet.en-us.md @@ -115,6 +115,7 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`. - `ALLOWED_TYPES`: **\<empty\>**: Comma-separated list of allowed file extensions (`.zip`), mime types (`text/plain`) or wildcard type (`image/*`, `audio/*`, `video/*`). Empty value or `*/*` allows all types. - `DEFAULT_PAGING_NUM`: **10**: The default paging number of releases user interface +- For settings related to file attachments on releases, see the `attachment` section. ### Repository - Signing (`repository.signing`) |