summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMorlinest <Morlinest@users.noreply.github.com>2017-09-27 14:41:52 +0200
committerAndrey Nering <andrey.nering@gmail.com>2017-09-27 09:41:52 -0300
commitcc84ca40d787d853186af6c16d328daa37d543da (patch)
tree92b77e428421f2c2ba734fca2efc201db1899e10
parent339d7de409fae0502f970e1ddd73c2a046236407 (diff)
downloadgitea-cc84ca40d787d853186af6c16d328daa37d543da.tar.gz
gitea-cc84ca40d787d853186af6c16d328daa37d543da.zip
Remove redudant issue LoadAttributes() calls (#2614)
-rw-r--r--models/issue.go7
-rw-r--r--routers/api/v1/repo/issue.go6
2 files changed, 1 insertions, 12 deletions
diff --git a/models/issue.go b/models/issue.go
index 7884507a27..0c68275d41 100644
--- a/models/issue.go
+++ b/models/issue.go
@@ -984,12 +984,7 @@ func GetIssueByRef(ref string) (*Issue, error) {
return nil, err
}
- issue, err := GetIssueByIndex(repo.ID, index)
- if err != nil {
- return nil, err
- }
-
- return issue, issue.LoadAttributes()
+ return GetIssueByIndex(repo.ID, index)
}
// GetRawIssueByIndex returns raw issue without loading attributes by index in a repository.
diff --git a/routers/api/v1/repo/issue.go b/routers/api/v1/repo/issue.go
index 9f51022f35..2debe67c3b 100644
--- a/routers/api/v1/repo/issue.go
+++ b/routers/api/v1/repo/issue.go
@@ -39,12 +39,6 @@ func ListIssues(ctx *context.APIContext) {
return
}
- err = models.IssueList(issues).LoadAttributes()
- if err != nil {
- ctx.Error(500, "LoadAttributes", err)
- return
- }
-
apiIssues := make([]*api.Issue, len(issues))
for i := range issues {
apiIssues[i] = issues[i].APIFormat()