Add env var check for update

2 files changed, 7 insertions, 5 deletions

diff --git a/cmd/update.go b/cmd/update.go
index 4cd62a7f54..1d27fb3e7b 100644
--- a/cmd/update.go
+++ b/cmd/update.go
@@ -28,8 +28,9 @@ func runUpdate(c *cli.Context) {
 	if c.IsSet("config") {
 		setting.CustomConf = c.String("config")
 	}
-	cmd := os.Getenv("SSH_ORIGINAL_COMMAND")
-	if cmd == "" {
+
+	if len(os.Getenv("SSH_ORIGINAL_COMMAND")) == 0 {
+		log.GitLogger.Trace("SSH_ORIGINAL_COMMAND is empty")
 		return
 	}
 
@@ -37,9 +38,9 @@ func runUpdate(c *cli.Context) {
 
 	args := c.Args()
 	if len(args) != 3 {
-		log.GitLogger.Fatal(2, "received less 3 parameters")
-	} else if args[0] == "" {
-		log.GitLogger.Fatal(2, "refName is empty, shouldn't use")
+		log.GitLogger.Fatal(2, "Arguments received are not equal to three")
+	} else if len(args[0]) == 0 {
+		log.GitLogger.Fatal(2, "First argument 'refName' is empty, shouldn't use")
 	}
 
 	task := models.UpdateTask{
diff --git a/modules/log/log.go b/modules/log/log.go
index a17c912f31..5e4bf6c120 100644
--- a/modules/log/log.go
+++ b/modules/log/log.go
@@ -37,6 +37,7 @@ func NewLogger(bufLen int64, mode, config string) {
 	}
 }
 
+// FIXME: use same log level as other loggers.
 func NewGitLogger(logPath string) {
 	os.MkdirAll(path.Dir(logPath), os.ModePerm)
 	GitLogger = newLogger(0)