diff options
| author | Dennis Menschel <menschel-d@posteo.de> | 2018-08-06 13:52:53 +0200 |
|---|---|---|
| committer | Lauris BH <lauris@nix.lv> | 2018-08-06 14:52:53 +0300 |
| commit | 9c0a374f3f1cb98e0861ecf542036b5fb1f23ff2 (patch) | |
| tree | 3a7d59a81c7cf98c93a9bff589dc6e868f1a7150 | |
| parent | 9ea327f1f7eb4f05e4b8dbf7e8d8dbfed2e78127 (diff) | |
| download | gitea-9c0a374f3f1cb98e0861ecf542036b5fb1f23ff2.tar.gz gitea-9c0a374f3f1cb98e0861ecf542036b5fb1f23ff2.zip | |
Fix integer constant overflows in tests (#4616)
* Use integer limit value [1] instead of hard-coded magic constant for
NonexistentID.
* Explicitly use int64 in order to avoid the following errors on 32 bit
architectures:
# code.gitea.io/gitea/integrations
./api_admin_test.go:50:34: constant 9223372036854775807 overflows int
./api_token_test.go:47:34: constant 9223372036854775807 overflows int
[...]
# code.gitea.io/gitea/models
./action_test.go:179:15: constant 9223372036854775807 overflows int
[1] https://golang.org/pkg/math/#pkg-constants
Signed-off-by: Dennis Menschel <menschel-d@posteo.de>
| -rw-r--r-- | models/unit_tests.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/models/unit_tests.go b/models/unit_tests.go index 9013fb9871..2b7f0d0151 100644 --- a/models/unit_tests.go +++ b/models/unit_tests.go @@ -7,6 +7,7 @@ package models import ( "fmt" "io/ioutil" + "math" "net/url" "os" "path/filepath" @@ -23,7 +24,7 @@ import ( ) // NonexistentID an ID that will never exist -const NonexistentID = 9223372036854775807 +const NonexistentID = int64(math.MaxInt64) // giteaRoot a path to the gitea root var giteaRoot string |