summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJelle Hulter <jellehulter@gmail.com>2021-09-18 17:44:45 +0200
committerGitHub <noreply@github.com>2021-09-18 16:44:45 +0100
commitb74a0f9060d5fda341f5554ef529a2006308c6ab (patch)
tree105c6e61f10760cc6c3be05601d3755450709f69
parent8fb3a50a3791147f992089f8b9f986e9b94542d8 (diff)
downloadgitea-b74a0f9060d5fda341f5554ef529a2006308c6ab.tar.gz
gitea-b74a0f9060d5fda341f5554ef529a2006308c6ab.zip
Fixed issue where creating a reference of an issue would create a tag with the full name instead of the username if this is the default in the .ini file (#17074)
Adds an extra attribute to every issue comment containing the actual username, such that it can be used to tag the original author when clicking on "Reference in new issue" (#17073) Fix #17073
-rw-r--r--templates/repo/issue/view_content/context_menu.tmpl2
-rw-r--r--web_src/js/index.js2
2 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/issue/view_content/context_menu.tmpl b/templates/repo/issue/view_content/context_menu.tmpl
index fdefde979d..71ce03a4ca 100644
--- a/templates/repo/issue/view_content/context_menu.tmpl
+++ b/templates/repo/issue/view_content/context_menu.tmpl
@@ -17,7 +17,7 @@
<div class="item context" data-clipboard-text="{{$referenceUrl}}">{{.ctx.i18n.Tr "repo.issues.context.copy_link"}}</div>
<div class="item context quote-reply {{if .diff}}quote-reply-diff{{end}}" data-target="{{.item.ID}}">{{.ctx.i18n.Tr "repo.issues.context.quote_reply"}}</div>
{{if not .ctx.UnitIssuesGlobalDisabled}}
- <div class="item context reference-issue" data-target="{{.item.ID}}" data-modal="#reference-issue-modal" data-poster="{{.item.Poster.GetDisplayName}}" data-reference="{{$referenceUrl}}">{{.ctx.i18n.Tr "repo.issues.context.reference_issue"}}</div>
+ <div class="item context reference-issue" data-target="{{.item.ID}}" data-modal="#reference-issue-modal" data-poster="{{.item.Poster.GetDisplayName}}" data-poster-username="{{.item.Poster.Name}}" data-reference="{{$referenceUrl}}">{{.ctx.i18n.Tr "repo.issues.context.reference_issue"}}</div>
{{end}}
{{if or .ctx.Permission.IsAdmin .IsCommentPoster .ctx.HasIssuesOrPullsWritePermission}}
<div class="divider"></div>
diff --git a/web_src/js/index.js b/web_src/js/index.js
index 78caa51fd6..a092452e6b 100644
--- a/web_src/js/index.js
+++ b/web_src/js/index.js
@@ -997,7 +997,7 @@ async function initRepository() {
const content = $(`#comment-${$this.data('target')}`).text();
const subject = content.split('\n', 1)[0].slice(0, 255);
- const poster = $this.data('poster');
+ const poster = $this.data('poster-username');
const reference = $this.data('reference');
const $modal = $($this.data('modal'));