aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2023-03-18 22:08:38 +0100
committerGitHub <noreply@github.com>2023-03-18 17:08:38 -0400
commit53b609e3361d321a60946376971d6a3c46d4ddb9 (patch)
tree975c05ed5494c47da831230b44c29573e9566e19
parent7eede7f8de299a8e657937d237f9d62e44bdd79b (diff)
downloadgitea-53b609e3361d321a60946376971d6a3c46d4ddb9.tar.gz
gitea-53b609e3361d321a60946376971d6a3c46d4ddb9.zip
Fix JS error on compare page (#23551)
Fix regression from #23271. This code apparently runs on the compare page where there is no review button so check for existance of both button and content. <img width="1226" alt="Screenshot 2023-03-17 at 21 42 47" src="https://user-images.githubusercontent.com/115237/226040001-ec097edd-d926-4c80-9962-526f9b7eff19.png"> Fixes #23562
-rw-r--r--web_src/js/features/repo-issue.js28
1 files changed, 15 insertions, 13 deletions
diff --git a/web_src/js/features/repo-issue.js b/web_src/js/features/repo-issue.js
index f12b10efc2..e49b1b2726 100644
--- a/web_src/js/features/repo-issue.js
+++ b/web_src/js/features/repo-issue.js
@@ -516,20 +516,22 @@ export function initRepoPullRequestReview() {
const $panel = $reviewBtn.parent().find('.review-box-panel');
const $closeBtn = $panel.find('.close');
- const tippy = createTippy($reviewBtn[0], {
- content: $panel[0],
- placement: 'bottom',
- trigger: 'click',
- role: 'menu',
- maxWidth: 'none',
- interactive: true,
- hideOnClick: true,
- });
+ if ($reviewBtn.length && $panel.length) {
+ const tippy = createTippy($reviewBtn[0], {
+ content: $panel[0],
+ placement: 'bottom',
+ trigger: 'click',
+ role: 'menu',
+ maxWidth: 'none',
+ interactive: true,
+ hideOnClick: true,
+ });
- $closeBtn.on('click', (e) => {
- e.preventDefault();
- tippy.hide();
- });
+ $closeBtn.on('click', (e) => {
+ e.preventDefault();
+ tippy.hide();
+ });
+ }
$(document).on('click', 'a.add-code-comment', async function (e) {
if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745