summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBo-Yi Wu <appleboy.tw@gmail.com>2018-12-03 22:28:46 +0800
committertechknowlogick <hello@techknowlogick.com>2018-12-03 09:28:46 -0500
commit20c54f88b23bbf56ac3cc3a74baeed98d7ab0844 (patch)
tree9a87f51423742041ec66d46947000520030817d3
parent2d707fe5e663abb0be2127362c760446ce6cedab (diff)
downloadgitea-20c54f88b23bbf56ac3cc3a74baeed98d7ab0844.tar.gz
gitea-20c54f88b23bbf56ac3cc3a74baeed98d7ab0844.zip
refactor: replace lint to revive (#5422)
* refactor: replace lint to revive * make changes. Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
-rw-r--r--.revive.toml25
-rw-r--r--Makefile6
2 files changed, 28 insertions, 3 deletions
diff --git a/.revive.toml b/.revive.toml
new file mode 100644
index 0000000000..74743d5ef4
--- /dev/null
+++ b/.revive.toml
@@ -0,0 +1,25 @@
+ignoreGeneratedHeader = false
+severity = "warning"
+confidence = 0.8
+errorCode = 1
+warningCode = 1
+
+[rule.blank-imports]
+[rule.context-as-argument]
+[rule.context-keys-type]
+[rule.dot-imports]
+[rule.error-return]
+[rule.error-strings]
+[rule.error-naming]
+[rule.exported]
+[rule.if-return]
+[rule.increment-decrement]
+[rule.var-naming]
+[rule.var-declaration]
+[rule.package-comments]
+[rule.range]
+[rule.receiver-naming]
+[rule.time-naming]
+[rule.unexported-return]
+[rule.indent-error-flow]
+[rule.errorf]
diff --git a/Makefile b/Makefile
index 5e7e72df0b..f007665e71 100644
--- a/Makefile
+++ b/Makefile
@@ -128,10 +128,10 @@ errcheck:
.PHONY: lint
lint:
- @hash golint > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
- $(GO) get -u golang.org/x/lint/golint; \
+ @hash revive > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
+ $(GO) get -u github.com/mgechev/revive; \
fi
- for PKG in $(PACKAGES); do golint -set_exit_status $$PKG || exit 1; done;
+ revive -config .revive.toml -exclude=./vendor/... ./... || exit 1
.PHONY: misspell-check
misspell-check: