diff options
| author | delvh <leon@kske.dev> | 2023-02-16 06:57:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-16 00:57:25 -0500 |
| commit | 3361bbf058e0b9edb321a537e03cd196ae255873 (patch) | |
| tree | f5631b595bb56a3a1ecf152d9cfc88dfcfccd8a1 | |
| parent | 3f318a4bad432b206386ba31399f84341913caf4 (diff) | |
| download | gitea-3361bbf058e0b9edb321a537e03cd196ae255873.tar.gz gitea-3361bbf058e0b9edb321a537e03cd196ae255873.zip | |
Add `title` to PR file tree items (#22918)
Previously, a file/directory name was simply cut when it was too long.
Now, we display the browser-native tooltip (`title`) instead, so you can
still see it when hovering over it.
In this case, we don't use the normal `tippy` tooltips for three
reasons:
1. Vue components are not included in the global tooltip initialization
2. Vue components would need to initialize their tooltips themselves
whenever their content is changed
3. The tooltips are shown too long under the default configuration (the
tooltip one element above is still shown when hovering on the element
below)
Fixes #22915
## Appearance
## Room for future improvement
We could think about displaying the whole file path in the title, not
just its name.
This is not done at the moment:
---------
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
| -rw-r--r-- | web_src/js/components/DiffFileTreeItem.vue | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/web_src/js/components/DiffFileTreeItem.vue b/web_src/js/components/DiffFileTreeItem.vue index 245286dded..f0a3d909b9 100644 --- a/web_src/js/components/DiffFileTreeItem.vue +++ b/web_src/js/components/DiffFileTreeItem.vue @@ -1,5 +1,6 @@ <template> - <div v-show="show"> + <div v-show="show" class="tooltip" :title="item.name"> + <!--title instead of tooltip above as the tooltip needs too much work with the current methods, i.e. not being loaded or staying open for "too long"--> <div class="item" :class="item.isFile ? 'filewrapper gt-p-1' : ''"> <!-- Files --> <SvgIcon |