diff options
| author | Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> | 2020-11-02 16:58:14 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-02 10:58:14 -0500 |
| commit | 7f7e7f3ca432fa80f9f5a8a71c9c10a89ac43c4f (patch) | |
| tree | 225c7cd34f4c4984571ffc33d3588207e0055220 | |
| parent | 06268dcf53657ffe012abe878e1127ab4f954264 (diff) | |
| download | gitea-7f7e7f3ca432fa80f9f5a8a71c9c10a89ac43c4f.tar.gz gitea-7f7e7f3ca432fa80f9f5a8a71c9c10a89ac43c4f.zip | |
Fix 'add code comment' button being invisible all the time (#13389)
* Fix 'add code comment' button being invisible all the time
* Fix off-center icon
* Remove old JS hover hack
* Show on full-line hover
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
| -rw-r--r-- | web_src/js/index.js | 10 | ||||
| -rw-r--r-- | web_src/less/_review.less | 11 |
2 files changed, 5 insertions, 16 deletions
diff --git a/web_src/js/index.js b/web_src/js/index.js index 7c56703144..fa80b5fb65 100644 --- a/web_src/js/index.js +++ b/web_src/js/index.js @@ -1238,16 +1238,6 @@ function initPullRequestReview() { $(this).closest('.menu').toggle('visible'); }); - $('.code-view .lines-code,.code-view .lines-num') - .on('mouseenter', function () { - const parent = $(this).closest('td'); - $(this).closest('tr').addClass( - parent.hasClass('lines-num-old') || parent.hasClass('lines-code-old') ? 'focus-lines-old' : 'focus-lines-new' - ); - }) - .on('mouseleave', function () { - $(this).closest('tr').removeClass('focus-lines-new focus-lines-old'); - }); $('.add-code-comment').on('click', function (e) { if ($(e.target).hasClass('btn-add-single')) return; // https://github.com/go-gitea/gitea/issues/4745 e.preventDefault(); diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 26036abaf5..1163b831ce 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -1,7 +1,7 @@ .ui.button.add-code-comment { font-size: 14px; height: 16px; - line-height: 16px !important; + line-height: 12px !important; padding: 0; position: relative; width: 16px; @@ -17,6 +17,10 @@ } } +.diff-file-box .lines-code:hover .ui.button.add-code-comment { + opacity: 1; +} + .repository .diff-file-box .code-diff .add-comment-left, .repository .diff-file-box .code-diff .add-comment-right, .repository .diff-file-box .code-diff .add-code-comment .add-comment-left, @@ -40,11 +44,6 @@ } } -.focus-lines-new .ui.button.add-code-comment.add-code-comment-right, -.focus-lines-old .ui.button.add-code-comment.add-code-comment-left { - opacity: 1; -} - .comment-code-cloud { padding: 4px; padding-left: 0; |