diff options
| author | Giteabot <teabot@gitea.io> | 2024-01-11 12:31:24 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-11 04:31:24 +0000 |
| commit | 5e9fd0ab5e3ce6428d6fe93c0c477fadb918e11f (patch) | |
| tree | 0ebf2daa22cb941f75f79c5e412c0614657a6c2e | |
| parent | f220f4231af35150eed910cbdc44fac8f85cdfb3 (diff) | |
| download | gitea-5e9fd0ab5e3ce6428d6fe93c0c477fadb918e11f.tar.gz gitea-5e9fd0ab5e3ce6428d6fe93c0c477fadb918e11f.zip | |
Hide code related setting options in repository when code unit is disabled (#28631) (#28749)
Backport #28631 by @lunny
Since #20805, code can be hidden.
However, the related settings are still shown even though they don't
have any meaning then.
https://github.com/go-gitea/gitea/assets/81045/5fdee54d-ac81-418a-82f7-eadff048cedd
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
| -rw-r--r-- | templates/repo/settings/navbar.tmpl | 36 | ||||
| -rw-r--r-- | templates/repo/settings/options.tmpl | 2 |
2 files changed, 19 insertions, 19 deletions
diff --git a/templates/repo/settings/navbar.tmpl b/templates/repo/settings/navbar.tmpl index b16eb6076f..3bef0fa4c1 100644 --- a/templates/repo/settings/navbar.tmpl +++ b/templates/repo/settings/navbar.tmpl @@ -7,31 +7,31 @@ <a class="{{if .PageIsSettingsCollaboration}}active {{end}}item" href="{{.RepoLink}}/settings/collaboration"> {{ctx.Locale.Tr "repo.settings.collaboration"}} </a> - {{if not .Repository.IsEmpty}} - <a class="{{if .PageIsSettingsBranches}}active {{end}}item" href="{{.RepoLink}}/settings/branches"> - {{ctx.Locale.Tr "repo.settings.branches"}} - </a> - {{end}} - <a class="{{if .PageIsSettingsTags}}active {{end}}item" href="{{.RepoLink}}/settings/tags"> - {{ctx.Locale.Tr "repo.settings.tags"}} - </a> {{if not DisableWebhooks}} <a class="{{if .PageIsSettingsHooks}}active {{end}}item" href="{{.RepoLink}}/settings/hooks"> {{ctx.Locale.Tr "repo.settings.hooks"}} </a> {{end}} - {{if .SignedUser.CanEditGitHook}} - <a class="{{if .PageIsSettingsGitHooks}}active {{end}}item" href="{{.RepoLink}}/settings/hooks/git"> - {{ctx.Locale.Tr "repo.settings.githooks"}} + {{if and (.Repository.UnitEnabled $.Context $.UnitTypeCode) (not .Repository.IsEmpty)}} + <a class="{{if .PageIsSettingsBranches}}active {{end}}item" href="{{.RepoLink}}/settings/branches"> + {{ctx.Locale.Tr "repo.settings.branches"}} </a> - {{end}} - <a class="{{if .PageIsSettingsKeys}}active {{end}}item" href="{{.RepoLink}}/settings/keys"> - {{ctx.Locale.Tr "repo.settings.deploy_keys"}} - </a> - {{if .LFSStartServer}} - <a class="{{if .PageIsSettingsLFS}}active {{end}}item" href="{{.RepoLink}}/settings/lfs"> - {{ctx.Locale.Tr "repo.settings.lfs"}} + <a class="{{if .PageIsSettingsTags}}active {{end}}item" href="{{.RepoLink}}/settings/tags"> + {{ctx.Locale.Tr "repo.settings.tags"}} </a> + {{if .SignedUser.CanEditGitHook}} + <a class="{{if .PageIsSettingsGitHooks}}active {{end}}item" href="{{.RepoLink}}/settings/hooks/git"> + {{ctx.Locale.Tr "repo.settings.githooks"}} + </a> + {{end}} + <a class="{{if .PageIsSettingsKeys}}active {{end}}item" href="{{.RepoLink}}/settings/keys"> + {{ctx.Locale.Tr "repo.settings.deploy_keys"}} + </a> + {{if .LFSStartServer}} + <a class="{{if .PageIsSettingsLFS}}active {{end}}item" href="{{.RepoLink}}/settings/lfs"> + {{ctx.Locale.Tr "repo.settings.lfs"}} + </a> + {{end}} {{end}} {{if and .EnableActions (not .UnitActionsGlobalDisabled) (.Permission.CanRead $.UnitTypeActions)}} <details class="item toggleable-item" {{if or .PageIsSharedSettingsRunners .PageIsSharedSettingsSecrets .PageIsSharedSettingsVariables}}open{{end}}> diff --git a/templates/repo/settings/options.tmpl b/templates/repo/settings/options.tmpl index 5a32f5e7ae..8456bb409b 100644 --- a/templates/repo/settings/options.tmpl +++ b/templates/repo/settings/options.tmpl @@ -66,7 +66,7 @@ {{/* These variables exist to make the logic in the Settings window easier to comprehend and are not used later on. */}} {{$newMirrorsPartiallyEnabled := or (not .DisableNewPullMirrors) (not .DisableNewPushMirrors)}} {{/* .Repository.IsMirror is not always reliable if the repository is not actively acting as a mirror because of errors. */}} - {{$showMirrorSettings := or $newMirrorsPartiallyEnabled .Repository.IsMirror .PullMirror .PushMirrors}} + {{$showMirrorSettings := and (.Repository.UnitEnabled $.Context $.UnitTypeCode) (or $newMirrorsPartiallyEnabled .Repository.IsMirror .PullMirror .PushMirrors)}} {{$newMirrorsEntirelyEnabled := and (not .DisableNewPullMirrors) (not .DisableNewPushMirrors)}} {{$onlyNewPushMirrorsEnabled := and (not .DisableNewPushMirrors) .DisableNewPullMirrors}} {{$onlyNewPullMirrorsEnabled := and .DisableNewPushMirrors (not .DisableNewPullMirrors)}} |