summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpitpalme <pitpalme@users.noreply.github.com>2023-11-24 15:46:19 +0100
committerGitHub <noreply@github.com>2023-11-24 14:46:19 +0000
commiteacce14546874dbeeda1f3f71dca89e0fc5226e6 (patch)
tree94aa45adcae000048e80dd7e5f03143d26d346bb
parent2ac2796a4c15ba924a7d446c00c4822cd00ed1ba (diff)
downloadgitea-eacce14546874dbeeda1f3f71dca89e0fc5226e6.tar.gz
gitea-eacce14546874dbeeda1f3f71dca89e0fc5226e6.zip
Fix delete-orphaned-repos (#28200)
gitea doctor failed at checking and fixing 'delete-orphaned-repos', because table name 'user' needs quoting to be correctly recognized by at least PostgreSQL. fixes #28199
-rw-r--r--modules/doctor/repository.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/modules/doctor/repository.go b/modules/doctor/repository.go
index d69ba2048b..b3a03aa422 100644
--- a/modules/doctor/repository.go
+++ b/modules/doctor/repository.go
@@ -26,7 +26,7 @@ func handleDeleteOrphanedRepos(ctx context.Context, logger log.Logger, autofix b
// countOrphanedRepos count repository where user of owner_id do not exist
func countOrphanedRepos(ctx context.Context) (int64, error) {
- return db.CountOrphanedObjects(ctx, "repository", "user", "repository.owner_id=user.id")
+ return db.CountOrphanedObjects(ctx, "repository", "user", "repository.owner_id=`user`.id")
}
// deleteOrphanedRepos delete repository where user of owner_id do not exist
@@ -43,7 +43,7 @@ func deleteOrphanedRepos(ctx context.Context) (int64, error) {
default:
var ids []int64
if err := e.Table("`repository`").
- Join("LEFT", "`user`", "repository.owner_id=user.id").
+ Join("LEFT", "`user`", "repository.owner_id=`user`.id").
Where(builder.IsNull{"`user`.id"}).
Select("`repository`.id").Limit(batchSize).Find(&ids); err != nil {
return deleted, err