diff options
| author | John Olheiser <john.olheiser@gmail.com> | 2023-12-07 11:42:58 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-12-07 12:42:58 -0500 |
| commit | 4bf565358410c26a91447613dc0e930a6af87ff5 (patch) | |
| tree | 4961ce00d884d432fb1da2cc1fc20b68e312bc56 | |
| parent | d9c19899cd27c73dd1497c0da6bd00336d2182e6 (diff) | |
| download | gitea-4bf565358410c26a91447613dc0e930a6af87ff5.tar.gz gitea-4bf565358410c26a91447613dc0e930a6af87ff5.zip | |
Fix Docker meta action for releases (#28232)
Should fix #28229 and #28230 for next release.
Assuming I'm reading the docs correctly for the docker meta action:
https://github.com/docker/metadata-action#flavor-input
https://github.com/docker/metadata-action#latest-tag
1. We want `latest=false` for the RCs.
2. `latest` should happen already due to `auto` mode, however there's an
extra option for the `suffix` flavor.
This PR is ready, but leaving it as draft to make sure someone
double-checks my sleuth-work.
Signed-off-by: jolheiser <john.olheiser@gmail.com>
| -rw-r--r-- | .github/workflows/release-tag-rc.yml | 3 | ||||
| -rw-r--r-- | .github/workflows/release-tag-version.yml | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/.github/workflows/release-tag-rc.yml b/.github/workflows/release-tag-rc.yml index 02ec1a1b2d..d73d67aede 100644 --- a/.github/workflows/release-tag-rc.yml +++ b/.github/workflows/release-tag-rc.yml @@ -78,6 +78,8 @@ jobs: id: meta with: images: gitea/gitea + flavor: | + latest=false # 1.2.3-rc0 tags: | type=semver,pattern={{version}} @@ -109,6 +111,7 @@ jobs: images: gitea/gitea # each tag below will have the suffix of -rootless flavor: | + latest=false suffix=-rootless # 1.2.3-rc0 tags: | diff --git a/.github/workflows/release-tag-version.yml b/.github/workflows/release-tag-version.yml index 635507c48d..0379350900 100644 --- a/.github/workflows/release-tag-version.yml +++ b/.github/workflows/release-tag-version.yml @@ -86,7 +86,6 @@ jobs: # 1.2 # 1.2.3 tags: | - type=raw,value=latest type=semver,pattern={{major}} type=semver,pattern={{major}}.{{minor}} type=semver,pattern={{version}} @@ -118,14 +117,13 @@ jobs: images: gitea/gitea # each tag below will have the suffix of -rootless flavor: | - suffix=-rootless + suffix=-rootless,onlatest=true # this will generate tags in the following format (with -rootless suffix added): # latest # 1 # 1.2 # 1.2.3 tags: | - type=raw,value=latest type=semver,pattern={{major}} type=semver,pattern={{major}}.{{minor}} type=semver,pattern={{version}} |