diff options
| author | Kim "BKC" Carlbäcker <kim.carlbacker@gmail.com> | 2017-06-26 03:06:40 +0200 |
|---|---|---|
| committer | Lunny Xiao <xiaolunwen@gmail.com> | 2017-06-26 09:06:40 +0800 |
| commit | 5db8cf3bd1505c5c829de2a928d35ea19808b6c2 (patch) | |
| tree | 12e89843be5c5f7a750f27b23280298e6b45bb2b | |
| parent | 49d397a9ee83b5c85ea7abb6e52d7d2b053b59ba (diff) | |
| download | gitea-5db8cf3bd1505c5c829de2a928d35ea19808b6c2.tar.gz gitea-5db8cf3bd1505c5c829de2a928d35ea19808b6c2.zip | |
Always return valid go-get meta, even if unauthorized (#2010)
* Always return valid go-get meta, even if unauthorized
* don't leak information
| -rw-r--r-- | modules/context/context.go | 44 |
1 files changed, 41 insertions, 3 deletions
diff --git a/modules/context/context.go b/modules/context/context.go index e96bf5bd3f..7137a16723 100644 --- a/modules/context/context.go +++ b/modules/context/context.go @@ -10,6 +10,7 @@ import ( "html/template" "io" "net/http" + "path" "strings" "time" @@ -18,6 +19,7 @@ import ( "code.gitea.io/gitea/modules/base" "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" + "github.com/Unknwon/com" "github.com/go-macaron/cache" "github.com/go-macaron/csrf" "github.com/go-macaron/i18n" @@ -33,6 +35,7 @@ type Context struct { Flash *session.Flash Session session.Store + Link string // current request URL User *models.User IsSigned bool IsBasicAuth bool @@ -154,15 +157,50 @@ func Contexter() macaron.Handler { csrf: x, Flash: f, Session: sess, + Link: setting.AppSubURL + strings.TrimSuffix(c.Req.URL.Path, "/"), Repo: &Repository{ PullRequest: &PullRequest{}, }, Org: &Organization{}, } - // Compute current URL for real-time change language. - ctx.Data["Link"] = setting.AppSubURL + strings.TrimSuffix(ctx.Req.URL.Path, "/") - + c.Data["Link"] = ctx.Link ctx.Data["PageStartTime"] = time.Now() + // Quick responses appropriate go-get meta with status 200 + // regardless of if user have access to the repository, + // or the repository does not exist at all. + // This is particular a workaround for "go get" command which does not respect + // .netrc file. + if ctx.Query("go-get") == "1" { + ownerName := c.Params(":username") + repoName := c.Params(":reponame") + branchName := "master" + + owner, err := models.GetUserByName(ownerName) + if err == nil { + repo, err := models.GetRepositoryByName(owner.ID, repoName) + if err == nil && len(repo.DefaultBranch) > 0 { + branchName = repo.DefaultBranch + } + } + prefix := setting.AppURL + path.Join(ownerName, repoName, "src", branchName) + c.PlainText(http.StatusOK, []byte(com.Expand(` +<html> + <head> + <meta name="go-import" content="{GoGetImport} git {CloneLink}"> + <meta name="go-source" content="{GoGetImport} _ {GoDocDirectory} {GoDocFile}"> + </head> + <body> + go get {GoGetImport} + </body> +</html> +`, map[string]string{ + "GoGetImport": path.Join(setting.Domain, setting.AppSubURL, ctx.Link), + "CloneLink": models.ComposeHTTPSCloneURL(ownerName, repoName), + "GoDocDirectory": prefix + "{/dir}", + "GoDocFile": prefix + "{/dir}/{file}#L{line}", + }))) + return + } // Get user from session if logged in. ctx.User, ctx.IsBasicAuth = auth.SignedInUser(ctx.Context, ctx.Session) |