diff options
| author | Thomas Boerger <tboerger@suse.de> | 2016-11-28 16:57:42 +0100 |
|---|---|---|
| committer | Thomas Boerger <tboerger@suse.de> | 2016-11-28 16:57:42 +0100 |
| commit | 8def53ffcce755db5c9ef7e160f202fe576fa586 (patch) | |
| tree | 77b91501f9241cb453cb6d1c717322db82ae33e0 /CONTRIBUTING.md | |
| parent | b3abc2775f7b7d1815c7776eee26982f4c49a638 (diff) | |
| download | gitea-8def53ffcce755db5c9ef7e160f202fe576fa586.tar.gz gitea-8def53ffcce755db5c9ef7e160f202fe576fa586.zip | |
Add a pragraph to the k8s PR guide to contributors guide
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fc0b240af2..11e0d73d4f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,6 +30,12 @@ Before sending code out for review, run all the tests for the whole tree to make Changes to Gitea must be reviewed before they are accepted, no matter who makes the change even if an owner or a maintainer. We use GitHub's pull request workflow to do that and we also use [LGTM](http://lgtm.co) to ensure every PR is reviewed by at least 2 maintainers. +Please try to make your pull request easy to review for us. Please read the "[How to get faster PR reviews](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md)" guide, it got useful tips for any project you may want to contribute. See some of the points: + +* Make small pull requests. The smaller, the faster to review and the more likely it will be merged soon. +* Don't make changes unrelated to your PR. Maybe there are typos on some comments, maybe refactoring would welcome on a function... but if that is not related to you PR, please make *another* PR for that. +* Split big pull requests in multiple. An incremental change will be faster to review than a huge PR. + ## Sign your work The sign-off is a simple line at the end of the explanation for the patch. Your signature certifies that you wrote the patch or otherwise have the right to pass it on as an open-source patch. The rules are pretty simple: If you can certify [DCO](DCO), then you just add a line to every git commit message: |