diff options
| author | Felipe Leopoldo Sologuren Gutiérrez <fsologureng@users.noreply.github.com> | 2023-01-16 13:21:44 -0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-16 16:21:44 +0000 |
| commit | 04c97aa36473bc0070a2fe46e86dc645dc75ee85 (patch) | |
| tree | 409f98cebeaac4b9f8b2482574963c78897710bc /build/generate-bindata.go | |
| parent | da274380a7be72e0153a448611278b402e20ad7e (diff) | |
| download | gitea-04c97aa36473bc0070a2fe46e86dc645dc75ee85.tar.gz gitea-04c97aa36473bc0070a2fe46e86dc645dc75ee85.zip | |
Change use of Walk to WalkDir to improve disk performance (#22462)
As suggest by Go developers, use `filepath.WalkDir` instead of
`filepath.Walk` because [*Walk is less efficient than WalkDir,
introduced in Go 1.16, which avoids calling `os.Lstat` on every file or
directory visited](https://pkg.go.dev/path/filepath#Walk).
This proposition address that, in a similar way as
https://github.com/go-gitea/gitea/pull/22392 did.
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'build/generate-bindata.go')
| -rw-r--r-- | build/generate-bindata.go | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/build/generate-bindata.go b/build/generate-bindata.go index ecd5d5047c..2fcb7c2f2a 100644 --- a/build/generate-bindata.go +++ b/build/generate-bindata.go @@ -32,11 +32,15 @@ func needsUpdate(dir, filename string) (bool, []byte) { hasher := sha1.New() - err = filepath.Walk(dir, func(path string, info os.FileInfo, err error) error { + err = filepath.WalkDir(dir, func(path string, d os.DirEntry, err error) error { if err != nil { return err } - _, _ = hasher.Write([]byte(info.Name())) + info, err := d.Info() + if err != nil { + return err + } + _, _ = hasher.Write([]byte(d.Name())) _, _ = hasher.Write([]byte(info.ModTime().String())) _, _ = hasher.Write([]byte(strconv.FormatInt(info.Size(), 16))) return nil |