diff options
| author | KN4CK3R <admin@oldschoolhack.me> | 2021-09-09 09:06:54 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-09 08:06:54 +0100 |
| commit | cd78c30fd30231f9fe058231cfce6d7207071e89 (patch) | |
| tree | f2e89fae02f2f0271c97cf023ae64ccf30edc9cd /build | |
| parent | e14b52ea367867d2bc7829927278ee167a2eea58 (diff) | |
| download | gitea-cd78c30fd30231f9fe058231cfce6d7207071e89.tar.gz gitea-cd78c30fd30231f9fe058231cfce6d7207071e89.zip | |
Use filename as id/class prefix. (#16997)
Currently the svg minifier (`make svg`) rewrites all `id` and `class` attributes in svg files. Every file gets the ids `a, b, ...`. If multiple svgs with ids are used on a page these ids are conflicting and the results are broken images.
| minified ids | unique ids |
| - | - |
|  |  |
This PR adds a prefix (the filename) to every id/class.
Follow up problem: Because we embed svg images there are duplicated ids if one svg image is used multiple times on a page. As those ids refer to the same content it may be no real problem because browser handle that fine.
Diffstat (limited to 'build')
| -rwxr-xr-x | build/generate-svg.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/build/generate-svg.js b/build/generate-svg.js index f1704712f3..29b7d47693 100755 --- a/build/generate-svg.js +++ b/build/generate-svg.js @@ -30,6 +30,7 @@ async function processFile(file, {prefix, fullName} = {}) { {name: 'preset-default'}, {name: 'removeXMLNS'}, {name: 'removeDimensions'}, + {name: 'prefixIds', params: {prefix: () => name}}, {name: 'addClassesToSVGElement', params: {classNames: ['svg', name]}}, {name: 'addAttributesToSVGElement', params: {attributes: [{'width': '16'}, {'height': '16'}, {'aria-hidden': 'true'}]}}, ], |