diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-07-21 17:28:19 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-21 17:28:19 +0800 |
| commit | d0dbe52e76f3038777c3b50066e3636105387ca3 (patch) | |
| tree | 4c159ed98a365300b6145bde03a06c29dcd21794 /cmd/convert.go | |
| parent | 840830b655a65c0763e3fd4bd0ced9256d2081a5 (diff) | |
| download | gitea-d0dbe52e76f3038777c3b50066e3636105387ca3.tar.gz gitea-d0dbe52e76f3038777c3b50066e3636105387ca3.zip | |
Refactor to use urfave/cli/v2 (#25959)
Replace #10912
And there are many new tests to cover the CLI behavior
There were some concerns about the "option order in hook scripts"
(https://github.com/go-gitea/gitea/pull/10912#issuecomment-1137543314),
it's not a problem now. Because the hook script uses `/gitea hook
--config=/app.ini pre-receive` format. The "config" is a global option,
it can appear anywhere.
----
## ⚠️ BREAKING ⚠️
This PR does it best to avoid breaking anything. The major changes are:
* `gitea` itself won't accept web's options: `--install-port` / `--pid`
/ `--port` / `--quiet` / `--verbose` .... They are `web` sub-command's
options.
* Use `./gitea web --pid ....` instead
* `./gitea` can still run the `web` sub-command as shorthand, with
default options
* The sub-command's options must follow the sub-command
* Before: `./gitea --sub-opt subcmd` might equal to `./gitea subcmd
--sub-opt` (well, might not ...)
* After: only `./gitea subcmd --sub-opt` could be used
* The global options like `--config` are not affected
Diffstat (limited to 'cmd/convert.go')
| -rw-r--r-- | cmd/convert.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/cmd/convert.go b/cmd/convert.go index 8c7746fdf2..37a260cbd8 100644 --- a/cmd/convert.go +++ b/cmd/convert.go @@ -10,11 +10,11 @@ import ( "code.gitea.io/gitea/modules/log" "code.gitea.io/gitea/modules/setting" - "github.com/urfave/cli" + "github.com/urfave/cli/v2" ) // CmdConvert represents the available convert sub-command. -var CmdConvert = cli.Command{ +var CmdConvert = &cli.Command{ Name: "convert", Usage: "Convert the database", Description: "A command to convert an existing MySQL database from utf8 to utf8mb4 or MSSQL database from varchar to nvarchar", |