diff options
author | B-OnTheGo <42626718+beeonthego@users.noreply.github.com> | 2018-09-11 02:15:52 +1000 |
---|---|---|
committer | techknowlogick <techknowlogick@users.noreply.github.com> | 2018-09-10 12:15:52 -0400 |
commit | e47df0b301510a49b49fc43266f436b7d58a02b1 (patch) | |
tree | acc014c8e82a3b75754c9969f078b25579a523e9 /integrations/api_issue_label_test.go | |
parent | 387a4b09c1b62a2a5eb70b89559d5ae53032c989 (diff) | |
download | gitea-e47df0b301510a49b49fc43266f436b7d58a02b1.tar.gz gitea-e47df0b301510a49b49fc43266f436b7d58a02b1.zip |
Enforce token on api routes [fixed critical security issue #4357] (#4840)
Diffstat (limited to 'integrations/api_issue_label_test.go')
-rw-r--r-- | integrations/api_issue_label_test.go | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/integrations/api_issue_label_test.go b/integrations/api_issue_label_test.go index 1bfaa4303e..57ca07337d 100644 --- a/integrations/api_issue_label_test.go +++ b/integrations/api_issue_label_test.go @@ -23,12 +23,13 @@ func TestAPIAddIssueLabels(t *testing.T) { label := models.AssertExistsAndLoadBean(t, &models.Label{RepoID: repo.ID}).(*models.Label) owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User) - urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/labels", - owner.Name, repo.Name, issue.Index) + session := loginUser(t, owner.Name) + token := getTokenForLoggedInUser(t, session) + urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/labels?token=%s", + owner.Name, repo.Name, issue.Index, token) req := NewRequestWithJSON(t, "POST", urlStr, &api.IssueLabelsOption{ Labels: []int64{label.ID}, }) - session := loginUser(t, owner.Name) resp := session.MakeRequest(t, req, http.StatusOK) var apiLabels []*api.Label DecodeJSON(t, resp, &apiLabels) @@ -45,12 +46,13 @@ func TestAPIReplaceIssueLabels(t *testing.T) { label := models.AssertExistsAndLoadBean(t, &models.Label{RepoID: repo.ID}).(*models.Label) owner := models.AssertExistsAndLoadBean(t, &models.User{ID: repo.OwnerID}).(*models.User) - urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/labels", - owner.Name, repo.Name, issue.Index) + session := loginUser(t, owner.Name) + token := getTokenForLoggedInUser(t, session) + urlStr := fmt.Sprintf("/api/v1/repos/%s/%s/issues/%d/labels?token=%s", + owner.Name, repo.Name, issue.Index, token) req := NewRequestWithJSON(t, "PUT", urlStr, &api.IssueLabelsOption{ Labels: []int64{label.ID}, }) - session := loginUser(t, owner.Name) resp := session.MakeRequest(t, req, http.StatusOK) var apiLabels []*api.Label DecodeJSON(t, resp, &apiLabels) |