Remove local clones & make hooks run on merge/edit/upload (#6672)

* Add options to git.Clone to make it more capable

* Begin the process of removing the local copy and tidy up

* Remove Wiki LocalCopy Checkouts

* Remove the last LocalRepo helpers

* Remove WithTemporaryFile

* Enable push-hooks for these routes

* Ensure tests cope with hooks

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove Repository.LocalCopyPath()

* Move temporary repo to use the standard temporary path

* Fix the tests

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove LocalWikiPath

* Fix missing remove

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use AppURL for Oauth user link (#6894)

* Use AppURL for Oauth user link

Fix #6843

* Update oauth.go

* Update oauth.go

* internal/ssh: ignore env command totally (#6825)

* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue #6889

* Escape the commit message on issues update and title in telegram hook (#6901)

* update sdk to latest (#6903)

* improve description of branch protection (fix #6886) (#6906)

The branch protection description text were not quite accurate.

* Fix logging documentation (#6904)

* ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG

* Allow DISABLE_ROUTER_LOG to be set in the [log] section

* [skip ci] Updated translations via Crowdin

* Move sdk structs to modules/structs (#6905)

* move sdk structs to moduels/structs

* fix tests

* fix fmt

* fix swagger

* fix vendor

1 files changed, 67 insertions, 65 deletions

diff --git a/integrations/pull_status_test.go b/integrations/pull_status_test.go
index 2381444676..2a4d8e0b68 100644
--- a/integrations/pull_status_test.go
+++ b/integrations/pull_status_test.go
@@ -6,6 +6,7 @@ package integrations
 import (
 	"fmt"
 	"net/http"
+	"net/url"
 	"path"
 	"testing"
 
@@ -16,78 +17,79 @@ import (
 )
 
 func TestPullCreate_CommitStatus(t *testing.T) {
-	prepareTestEnv(t)
-	session := loginUser(t, "user1")
-	testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
-	testEditFileToNewBranch(t, session, "user1", "repo1", "master", "status1", "README.md", "status1")
-
-	url := path.Join("user1", "repo1", "compare", "master...status1")
-	req := NewRequestWithValues(t, "POST", url,
-		map[string]string{
-			"_csrf": GetCSRF(t, session, url),
-			"title": "pull request from status1",
-		},
-	)
-	session.MakeRequest(t, req, http.StatusFound)
-
-	req = NewRequest(t, "GET", "/user1/repo1/pulls")
-	resp := session.MakeRequest(t, req, http.StatusOK)
-	doc := NewHTMLParser(t, resp.Body)
-
-	// Request repository commits page
-	req = NewRequest(t, "GET", "/user1/repo1/pulls/1/commits")
-	resp = session.MakeRequest(t, req, http.StatusOK)
-	doc = NewHTMLParser(t, resp.Body)
-
-	// Get first commit URL
-	commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
-	assert.True(t, exists)
-	assert.NotEmpty(t, commitURL)
-
-	commitID := path.Base(commitURL)
-
-	statusList := []models.CommitStatusState{
-		models.CommitStatusPending,
-		models.CommitStatusError,
-		models.CommitStatusFailure,
-		models.CommitStatusWarning,
-		models.CommitStatusSuccess,
-	}
-
-	statesIcons := map[models.CommitStatusState]string{
-		models.CommitStatusPending: "circle icon yellow",
-		models.CommitStatusSuccess: "check icon green",
-		models.CommitStatusError:   "warning icon red",
-		models.CommitStatusFailure: "remove icon red",
-		models.CommitStatusWarning: "warning sign icon yellow",
-	}
-
-	// Update commit status, and check if icon is updated as well
-	for _, status := range statusList {
-
-		// Call API to add status for commit
-		token := getTokenForLoggedInUser(t, session)
-		req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/repos/user1/repo1/statuses/%s?token=%s", commitID, token),
-			api.CreateStatusOption{
-				State:       api.StatusState(status),
-				TargetURL:   "http://test.ci/",
-				Description: "",
-				Context:     "testci",
+	onGiteaRun(t, func(t *testing.T, u *url.URL) {
+		session := loginUser(t, "user1")
+		testRepoFork(t, session, "user2", "repo1", "user1", "repo1")
+		testEditFileToNewBranch(t, session, "user1", "repo1", "master", "status1", "README.md", "status1")
+
+		url := path.Join("user1", "repo1", "compare", "master...status1")
+		req := NewRequestWithValues(t, "POST", url,
+			map[string]string{
+				"_csrf": GetCSRF(t, session, url),
+				"title": "pull request from status1",
 			},
 		)
-		session.MakeRequest(t, req, http.StatusCreated)
+		session.MakeRequest(t, req, http.StatusFound)
 
-		req = NewRequestf(t, "GET", "/user1/repo1/pulls/1/commits")
+		req = NewRequest(t, "GET", "/user1/repo1/pulls")
+		resp := session.MakeRequest(t, req, http.StatusOK)
+		doc := NewHTMLParser(t, resp.Body)
+
+		// Request repository commits page
+		req = NewRequest(t, "GET", "/user1/repo1/pulls/1/commits")
 		resp = session.MakeRequest(t, req, http.StatusOK)
 		doc = NewHTMLParser(t, resp.Body)
 
-		commitURL, exists = doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
+		// Get first commit URL
+		commitURL, exists := doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
 		assert.True(t, exists)
 		assert.NotEmpty(t, commitURL)
-		assert.EqualValues(t, commitID, path.Base(commitURL))
 
-		cls, ok := doc.doc.Find("#commits-table tbody tr td.message i.commit-status").Last().Attr("class")
-		assert.True(t, ok)
-		assert.EqualValues(t, "commit-status "+statesIcons[status], cls)
-	}
+		commitID := path.Base(commitURL)
+
+		statusList := []models.CommitStatusState{
+			models.CommitStatusPending,
+			models.CommitStatusError,
+			models.CommitStatusFailure,
+			models.CommitStatusWarning,
+			models.CommitStatusSuccess,
+		}
+
+		statesIcons := map[models.CommitStatusState]string{
+			models.CommitStatusPending: "circle icon yellow",
+			models.CommitStatusSuccess: "check icon green",
+			models.CommitStatusError:   "warning icon red",
+			models.CommitStatusFailure: "remove icon red",
+			models.CommitStatusWarning: "warning sign icon yellow",
+		}
+
+		// Update commit status, and check if icon is updated as well
+		for _, status := range statusList {
+
+			// Call API to add status for commit
+			token := getTokenForLoggedInUser(t, session)
+			req = NewRequestWithJSON(t, "POST", fmt.Sprintf("/api/v1/repos/user1/repo1/statuses/%s?token=%s", commitID, token),
+				api.CreateStatusOption{
+					State:       api.StatusState(status),
+					TargetURL:   "http://test.ci/",
+					Description: "",
+					Context:     "testci",
+				},
+			)
+			session.MakeRequest(t, req, http.StatusCreated)
+
+			req = NewRequestf(t, "GET", "/user1/repo1/pulls/1/commits")
+			resp = session.MakeRequest(t, req, http.StatusOK)
+			doc = NewHTMLParser(t, resp.Body)
+
+			commitURL, exists = doc.doc.Find("#commits-table tbody tr td.sha a").Last().Attr("href")
+			assert.True(t, exists)
+			assert.NotEmpty(t, commitURL)
+			assert.EqualValues(t, commitID, path.Base(commitURL))
+
+			cls, ok := doc.doc.Find("#commits-table tbody tr td.message i.commit-status").Last().Attr("class")
+			assert.True(t, ok)
+			assert.EqualValues(t, "commit-status "+statesIcons[status], cls)
+		}
+	})
 }