diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2021-04-11 04:49:10 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-10 16:49:10 -0400 |
| commit | 1fc1d605178ead73e31d6e068af3f3e38c28a803 (patch) | |
| tree | a2889951382b582255bc0bec51669fe6d41b6e14 /integrations | |
| parent | c680eb2cc74823f017f5ad5a4c9e8094cde311f4 (diff) | |
| download | gitea-1fc1d605178ead73e31d6e068af3f3e38c28a803.tar.gz gitea-1fc1d605178ead73e31d6e068af3f3e38c28a803.zip | |
Fix delete nonexist oauth application 500 and prevent deadlock (#15384)
* Fix delete nonexist oauth application 500
* Fix test
* Close the session
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Update integrations/api_oauth2_apps_test.go
* Fix more missed sess.Close
* Remove unnecessary blank line
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'integrations')
| -rw-r--r-- | integrations/api_oauth2_apps_test.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/integrations/api_oauth2_apps_test.go b/integrations/api_oauth2_apps_test.go index 998043a6fb..0ba56b6c9f 100644 --- a/integrations/api_oauth2_apps_test.go +++ b/integrations/api_oauth2_apps_test.go @@ -92,6 +92,10 @@ func testAPIDeleteOAuth2Application(t *testing.T) { session.MakeRequest(t, req, http.StatusNoContent) models.AssertNotExistsBean(t, &models.OAuth2Application{UID: oldApp.UID, Name: oldApp.Name}) + + // Delete again will return not found + req = NewRequest(t, "DELETE", urlStr) + session.MakeRequest(t, req, http.StatusNotFound) } func testAPIGetOAuth2Application(t *testing.T) { |