diff options
| author | zeripath <art27@cantab.net> | 2021-03-15 21:52:11 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-15 17:52:11 -0400 |
| commit | 6e423d5573c20b78d6e21cb044e8f4d5de5b288a (patch) | |
| tree | 61d2e282bc652b8254271fdd9e19b87a386b5dc7 /integrations | |
| parent | f268b4896b1030761b28f1f8923d77d87adb8f0b (diff) | |
| download | gitea-6e423d5573c20b78d6e21cb044e8f4d5de5b288a.tar.gz gitea-6e423d5573c20b78d6e21cb044e8f4d5de5b288a.zip | |
Ensure validation occurs on clone addresses too (#14994)
* Ensure validation occurs on clone addresses too
Fix #14984
Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix lint
Signed-off-by: Andrew Thornton <art27@cantab.net>
* fix test
Signed-off-by: Andrew Thornton <art27@cantab.net>
* Fix api tests
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Diffstat (limited to 'integrations')
| -rw-r--r-- | integrations/api_repo_test.go | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/integrations/api_repo_test.go b/integrations/api_repo_test.go index 3404e050cf..cfd3b58d64 100644 --- a/integrations/api_repo_test.go +++ b/integrations/api_repo_test.go @@ -309,7 +309,7 @@ func TestAPIRepoMigrate(t *testing.T) { {ctxUserID: 2, userID: 1, cloneURL: "https://github.com/go-gitea/test_repo.git", repoName: "git-bad", expectedStatus: http.StatusForbidden}, {ctxUserID: 2, userID: 3, cloneURL: "https://github.com/go-gitea/test_repo.git", repoName: "git-org", expectedStatus: http.StatusCreated}, {ctxUserID: 2, userID: 6, cloneURL: "https://github.com/go-gitea/test_repo.git", repoName: "git-bad-org", expectedStatus: http.StatusForbidden}, - {ctxUserID: 2, userID: 3, cloneURL: "https://localhost:3000/user/test_repo.git", repoName: "local-ip", expectedStatus: http.StatusUnprocessableEntity}, + {ctxUserID: 2, userID: 3, cloneURL: "https://localhost:3000/user/test_repo.git", repoName: "private-ip", expectedStatus: http.StatusUnprocessableEntity}, {ctxUserID: 2, userID: 3, cloneURL: "https://10.0.0.1/user/test_repo.git", repoName: "private-ip", expectedStatus: http.StatusUnprocessableEntity}, } @@ -330,11 +330,8 @@ func TestAPIRepoMigrate(t *testing.T) { switch respJSON["message"] { case "Remote visit addressed rate limitation.": t.Log("test hit github rate limitation") - case "migrate from '10.0.0.1' is not allowed: the host resolve to a private ip address '10.0.0.1'": + case "You are not allowed to import from private IPs.": assert.EqualValues(t, "private-ip", testCase.repoName) - case "migrate from 'localhost:3000' is not allowed: the host resolve to a private ip address '::1'", - "migrate from 'localhost:3000' is not allowed: the host resolve to a private ip address '127.0.0.1'": - assert.EqualValues(t, "local-ip", testCase.repoName) default: t.Errorf("unexpected error '%v' on url '%s'", respJSON["message"], testCase.cloneURL) } |