diff options
| author | zeripath <art27@cantab.net> | 2021-12-24 16:50:49 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-25 00:50:49 +0800 |
| commit | 16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c (patch) | |
| tree | 7a95791e32336c53bfe75544b5dac4e6b31cc800 /integrations | |
| parent | 26070eb818a09e7123c178434e73c9def88ea8e7 (diff) | |
| download | gitea-16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c.tar.gz gitea-16adaaeaa3d6ebe19e203e5626120ed1cd4fea6c.zip | |
Instead of using routerCtx just escape the url before routing (#18086)
A consequence of forcibly setting the RoutePath to the escaped url is that the
auto routing to endpoints without terminal slashes fails (Causing #18060.) This
failure raises the possibility that forcibly setting the RoutePath causes other
unexpected behaviors too.
Therefore, instead we should simply pre-escape the URL in the process registering
handler. Then the request URL will be properly escaped for all the following calls.
Fix #17938
Fix #18060
Replace #18062
Replace #17997
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'integrations')
| -rw-r--r-- | integrations/links_test.go | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/integrations/links_test.go b/integrations/links_test.go index 872234e61f..d1d90cd5e3 100644 --- a/integrations/links_test.go +++ b/integrations/links_test.go @@ -33,6 +33,7 @@ func TestLinksNoLogin(t *testing.T) { "/user/forgot_password", "/api/swagger", "/user2/repo1", + "/user2/repo1/", "/user2/repo1/projects", "/user2/repo1/projects/1", "/assets/img/404.png", @@ -61,16 +62,6 @@ func TestRedirectsNoLogin(t *testing.T) { resp := MakeRequest(t, req, http.StatusFound) assert.EqualValues(t, path.Join(setting.AppSubURL, redirectLink), test.RedirectURL(resp)) } - - var temporaryRedirects = map[string]string{ - "/user2/repo1/": "/user2/repo1", - } - for link, redirectLink := range temporaryRedirects { - req := NewRequest(t, "GET", link) - resp := MakeRequest(t, req, http.StatusTemporaryRedirect) - assert.EqualValues(t, path.Join(setting.AppSubURL, redirectLink), test.RedirectURL(resp)) - } - } func TestNoLoginNotExist(t *testing.T) { |