diff options
| author | zeripath <art27@cantab.net> | 2021-09-27 19:07:19 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-09-27 19:07:19 +0100 |
| commit | e8574f2f7d4648b5b3fda48f3e31599a6b9dd40b (patch) | |
| tree | f7ea29c89e569ef8a17da14780512866c8916610 /models/access.go | |
| parent | b5856c443729c6825618595a0e746202553aa95c (diff) | |
| download | gitea-e8574f2f7d4648b5b3fda48f3e31599a6b9dd40b.tar.gz gitea-e8574f2f7d4648b5b3fda48f3e31599a6b9dd40b.zip | |
Nicely handle missing user in collaborations (#17049)
* Nicely handle missing user in collaborations
It is possible to have a collaboration in a repository which refers to a no-longer
existing user. This causes the repository transfer to fail with an unusual error.
This PR makes `repo.getCollaborators()` nicely handle the missing user by ghosting
the collaboration but also adds consistency check. It also adds an
Access consistency check.
Fix #17044
Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Diffstat (limited to 'models/access.go')
| -rw-r--r-- | models/access.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/models/access.go b/models/access.go index 560234aae8..7bbc04bd45 100644 --- a/models/access.go +++ b/models/access.go @@ -230,6 +230,9 @@ func (repo *Repository) refreshCollaboratorAccesses(e db.Engine, accessMap map[i return fmt.Errorf("getCollaborations: %v", err) } for _, c := range collaborators { + if c.User.IsGhost() { + continue + } updateUserAccess(accessMap, c.User, c.Collaboration.Mode) } return nil |