aboutsummaryrefslogtreecommitdiffstats
path: root/models/activities/repo_activity.go
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2024-01-27 19:02:51 +0100
committerGitHub <noreply@github.com>2024-01-27 18:02:51 +0000
commit60e4a98ab07dcf3bd86cf630c79e6433c3ef3e84 (patch)
tree6ccd4d32471410f2b20d3c853dc45268cc2a5e07 /models/activities/repo_activity.go
parent0e650dca3076bbf8e1a4d1a80cef3275a51af658 (diff)
downloadgitea-60e4a98ab07dcf3bd86cf630c79e6433c3ef3e84.tar.gz
gitea-60e4a98ab07dcf3bd86cf630c79e6433c3ef3e84.zip
Preserve BOM in web editor (#28935)
The `ToUTF8*` functions were stripping BOM, while BOM is actually valid in UTF8, so the stripping must be optional depending on use case. This does: - Add a options struct to all `ToUTF8*` functions, that by default will strip BOM to preserve existing behaviour - Remove `ToUTF8` function, it was dead code - Rename `ToUTF8WithErr` to `ToUTF8` - Preserve BOM in Monaco Editor - Remove a unnecessary newline in the textarea value. Browsers did ignore it, it seems but it's better not to rely on this behaviour. Fixes: https://github.com/go-gitea/gitea/issues/28743 Related: https://github.com/go-gitea/gitea/issues/6716 which seems to have once introduced a mechanism that strips and re-adds the BOM, but from what I can tell, this mechanism was removed at some point after that PR.
Diffstat (limited to 'models/activities/repo_activity.go')
0 files changed, 0 insertions, 0 deletions