diff options
| author | Lunny Xiao <xiaolunwen@gmail.com> | 2021-05-01 02:08:46 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-30 20:08:46 +0200 |
| commit | f5eb33c354fc8e61cc1be221f3b7256fd7b66615 (patch) | |
| tree | 2c9628831ac89d4049cdf71bd5ddd8eb4e7f7162 /models/consistency.go | |
| parent | c80d7f33b67ad1beff7378bcba3aa44ac84669e9 (diff) | |
| download | gitea-f5eb33c354fc8e61cc1be221f3b7256fd7b66615.tar.gz gitea-f5eb33c354fc8e61cc1be221f3b7256fd7b66615.zip | |
Fix orphaned objects deletion bug (#15657)
* Fix orphaned objects deletion bug
* extend test
Co-authored-by: 6543 <6543@obermui.de>
Diffstat (limited to 'models/consistency.go')
| -rw-r--r-- | models/consistency.go | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/models/consistency.go b/models/consistency.go index a1a2bf7bb5..77a8018266 100644 --- a/models/consistency.go +++ b/models/consistency.go @@ -296,11 +296,15 @@ func CountOrphanedObjects(subject, refobject, joinCond string) (int64, error) { // DeleteOrphanedObjects delete subjects with have no existing refobject anymore func DeleteOrphanedObjects(subject, refobject, joinCond string) error { - _, err := x.In("id", builder.Select("`"+subject+"`.id"). + subQuery := builder.Select("`"+subject+"`.id"). From("`"+subject+"`"). Join("LEFT", "`"+refobject+"`", joinCond). - Where(builder.IsNull{"`" + refobject + "`.id"})). - Delete("`" + subject + "`") + Where(builder.IsNull{"`" + refobject + "`.id"}) + sql, args, err := builder.Delete(builder.In("id", subQuery)).From("`" + subject + "`").ToSQL() + if err != nil { + return err + } + _, err = x.Exec(append([]interface{}{sql}, args...)...) return err } |