aboutsummaryrefslogtreecommitdiffstats
path: root/models/db
diff options
context:
space:
mode:
authorLunny Xiao <xiaolunwen@gmail.com>2022-12-02 11:15:36 +0800
committerGitHub <noreply@github.com>2022-12-02 11:15:36 +0800
commitf7ade6de7c1c4991c650d6b96e6407053e6bdae7 (patch)
tree35a935e1d99b8254a892524dfd1ec6d27f492959 /models/db
parent64973cf18fcd21179fb7612b15914691ee24c657 (diff)
downloadgitea-f7ade6de7c1c4991c650d6b96e6407053e6bdae7.tar.gz
gitea-f7ade6de7c1c4991c650d6b96e6407053e6bdae7.zip
Fix generate index failure possibility on postgres (#21998)
@wxiaoguang Please review Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'models/db')
-rw-r--r--models/db/index.go20
1 files changed, 20 insertions, 0 deletions
diff --git a/models/db/index.go b/models/db/index.go
index ca664c9cf1..f840a62c89 100644
--- a/models/db/index.go
+++ b/models/db/index.go
@@ -7,6 +7,9 @@ import (
"context"
"errors"
"fmt"
+ "strconv"
+
+ "code.gitea.io/gitea/modules/setting"
)
// ResourceIndex represents a resource index which could be used as issue/release and others
@@ -55,8 +58,25 @@ func SyncMaxResourceIndex(ctx context.Context, tableName string, groupID, maxInd
return nil
}
+func postgresGetNextResourceIndex(ctx context.Context, tableName string, groupID int64) (int64, error) {
+ res, err := GetEngine(ctx).Query(fmt.Sprintf("INSERT INTO %s (group_id, max_index) "+
+ "VALUES (?,1) ON CONFLICT (group_id) DO UPDATE SET max_index = %s.max_index+1 RETURNING max_index",
+ tableName, tableName), groupID)
+ if err != nil {
+ return 0, err
+ }
+ if len(res) == 0 {
+ return 0, ErrGetResourceIndexFailed
+ }
+ return strconv.ParseInt(string(res[0]["max_index"]), 10, 64)
+}
+
// GetNextResourceIndex generates a resource index, it must run in the same transaction where the resource is created
func GetNextResourceIndex(ctx context.Context, tableName string, groupID int64) (int64, error) {
+ if setting.Database.UsePostgreSQL {
+ return postgresGetNextResourceIndex(ctx, tableName, groupID)
+ }
+
e := GetEngine(ctx)
// try to update the max_index to next value, and acquire the write-lock for the record