Fix org visibility bug when git cloning (#6743)

* fix org visibility bug

* fix permission check

* add integration tests

* fix tests

* change test user name for easier maintainance and fix test

* fix test git repo name

3 files changed, 164 insertions, 0 deletions

diff --git a/models/fixtures/repo_unit.yml b/models/fixtures/repo_unit.yml
index e2bb4388d7..2b325cba88 100644
--- a/models/fixtures/repo_unit.yml
+++ b/models/fixtures/repo_unit.yml
@@ -291,3 +291,87 @@
   type: 3
   config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowRebaseMerge\":true,\"AllowSquash\":true}"
   created_unix: 946684810
+
+-
+  id: 43
+  repo_id: 38
+  type: 1
+  config: "{}"
+  created_unix: 946684810
+
+-
+  id: 44
+  repo_id: 38
+  type: 2
+  config: "{\"EnableTimetracker\":true,\"AllowOnlyContributorsToTrackTime\":true}"
+  created_unix: 946684810
+
+-
+  id: 45
+  repo_id: 38
+  type: 3
+  config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowRebaseMerge\":true,\"AllowSquash\":true}"
+  created_unix: 946684810
+
+-
+  id: 46
+  repo_id: 39
+  type: 1
+  config: "{}"
+  created_unix: 946684810
+
+-
+  id: 47
+  repo_id: 39
+  type: 2
+  config: "{\"EnableTimetracker\":true,\"AllowOnlyContributorsToTrackTime\":true}"
+  created_unix: 946684810
+
+-
+  id: 48
+  repo_id: 39
+  type: 3
+  config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowRebaseMerge\":true,\"AllowSquash\":true}"
+  created_unix: 946684810
+
+-
+  id: 49
+  repo_id: 40
+  type: 1
+  config: "{}"
+  created_unix: 946684810
+
+-
+  id: 50
+  repo_id: 40
+  type: 2
+  config: "{\"EnableTimetracker\":true,\"AllowOnlyContributorsToTrackTime\":true}"
+  created_unix: 946684810
+
+-
+  id: 51
+  repo_id: 40
+  type: 3
+  config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowRebaseMerge\":true,\"AllowSquash\":true}"
+  created_unix: 946684810
+
+-
+  id: 52
+  repo_id: 41
+  type: 1
+  config: "{}"
+  created_unix: 946684810
+
+-
+  id: 53
+  repo_id: 41
+  type: 2
+  config: "{\"EnableTimetracker\":true,\"AllowOnlyContributorsToTrackTime\":true}"
+  created_unix: 946684810
+
+-
+  id: 54
+  repo_id: 41
+  type: 3
+  config: "{\"IgnoreWhitespaceConflicts\":false,\"AllowMerge\":true,\"AllowRebase\":true,\"AllowRebaseMerge\":true,\"AllowSquash\":true}"
+  created_unix: 946684810
\ No newline at end of file
diff --git a/models/fixtures/repository.yml b/models/fixtures/repository.yml
index b0fd8fcc5c..083182e2bc 100644
--- a/models/fixtures/repository.yml
+++ b/models/fixtures/repository.yml
@@ -452,3 +452,47 @@
   num_forks: 0
   num_issues: 0
   is_mirror: false
+
+-
+  id: 38
+  owner_id: 22
+  lower_name: public_repo_on_limited_org
+  name: public_repo_on_limited_org
+  is_private: false
+  num_stars: 0
+  num_forks: 0
+  num_issues: 0
+  is_mirror: false
+
+-
+  id: 39
+  owner_id: 22
+  lower_name: private_repo_on_limited_org
+  name: private_repo_on_limited_org
+  is_private: true
+  num_stars: 0
+  num_forks: 0
+  num_issues: 0
+  is_mirror: false
+
+-
+  id: 40
+  owner_id: 23
+  lower_name: public_repo_on_private_org
+  name: public_repo_on_private_org
+  is_private: false
+  num_stars: 0
+  num_forks: 0
+  num_issues: 0
+  is_mirror: false
+
+-
+  id: 41
+  owner_id: 23
+  lower_name: private_repo_on_private_org
+  name: private_repo_on_private_org
+  is_private: true
+  num_stars: 0
+  num_forks: 0
+  num_issues: 0
+  is_mirror: false
\ No newline at end of file
diff --git a/models/fixtures/user.yml b/models/fixtures/user.yml
index 9a1d558e6b..ed60e7f5ea 100644
--- a/models/fixtures/user.yml
+++ b/models/fixtures/user.yml
@@ -330,3 +330,39 @@
   avatar_email: user21@example.com
   num_repos: 2
   is_active: true
+
+-
+  id: 22
+  lower_name: limited_org
+  name: limited_org
+  full_name: Limited Org
+  email: limited_org@example.com
+  passwd: 7d93daa0d1e6f2305cc8fa496847d61dc7320bb16262f9c55dd753480207234cdd96a93194e408341971742f4701772a025a # password
+  type: 1 # organization
+  salt: ZogKvWdyEx
+  is_admin: false
+  avatar: avatar22
+  avatar_email: limited_org@example.com
+  num_repos: 2
+  is_active: true
+  num_members: 0
+  num_teams: 0
+  visibility: 1
+
+-
+  id: 23
+  lower_name: privated_org
+  name: privated_org
+  full_name: Privated Org
+  email: privated_org@example.com
+  passwd: 7d93daa0d1e6f2305cc8fa496847d61dc7320bb16262f9c55dd753480207234cdd96a93194e408341971742f4701772a025a # password
+  type: 1 # organization
+  salt: ZogKvWdyEx
+  is_admin: false
+  avatar: avatar23
+  avatar_email: privated_org@example.com
+  num_repos: 2
+  is_active: true
+  num_members: 0
+  num_teams: 0
+  visibility: 2
\ No newline at end of file