diff options
| author | David Svantesson <davidsvantesson@gmail.com> | 2019-10-25 16:46:37 +0200 |
|---|---|---|
| committer | Lunny Xiao <xiaolunwen@gmail.com> | 2019-10-25 22:46:37 +0800 |
| commit | 6aa3f8bc29cb1ed3a1b165cbf526079a751c8c71 (patch) | |
| tree | d18aafe7855f9d21fb0d8d7104e7ac7b4aba72b2 /models/issue_assignees_test.go | |
| parent | c34e58fc008d53a5ec92cadadab2b13fb4e0ae94 (diff) | |
| download | gitea-6aa3f8bc29cb1ed3a1b165cbf526079a751c8c71.tar.gz gitea-6aa3f8bc29cb1ed3a1b165cbf526079a751c8c71.zip | |
Mail assignee when issue/pull request is assigned (#8546)
* Send email to assigned user
* Only send mail if enabled
* Mail also when assigned through API
* Need to refactor functions from models to issue service
* Refer to issue index rather than ID
* Disable email notifications completly at initalization if global disable
* Check of user enbled mail shall be in mail notification function only
* Initialize notifications from routers init function.
* Use the assigned comment when sending assigned mail
* Refactor so that assignees always added as separate step when new issue/pr.
* Check error from AddAssignees
* Check if user can be assiged to issue or pull request
* Missing return
* Refactor of CanBeAssigned check.
CanBeAssigned shall have same check as UI.
* Clarify function names (toggle rather than update/change), and clean up.
* Fix review comments.
* Flash error if assignees was not added when creating issue/pr
* Generate error if assignee users doesn't exist
Diffstat (limited to 'models/issue_assignees_test.go')
| -rw-r--r-- | models/issue_assignees_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/models/issue_assignees_test.go b/models/issue_assignees_test.go index d32f41737a..1c5b5e7a22 100644 --- a/models/issue_assignees_test.go +++ b/models/issue_assignees_test.go @@ -20,17 +20,17 @@ func TestUpdateAssignee(t *testing.T) { // Assign multiple users user2, err := GetUserByID(2) assert.NoError(t, err) - err = UpdateAssignee(issue, &User{ID: 1}, user2.ID) + _, _, err = issue.ToggleAssignee(&User{ID: 1}, user2.ID) assert.NoError(t, err) user3, err := GetUserByID(3) assert.NoError(t, err) - err = UpdateAssignee(issue, &User{ID: 1}, user3.ID) + _, _, err = issue.ToggleAssignee(&User{ID: 1}, user3.ID) assert.NoError(t, err) user1, err := GetUserByID(1) // This user is already assigned (see the definition in fixtures), so running UpdateAssignee should unassign him assert.NoError(t, err) - err = UpdateAssignee(issue, &User{ID: 1}, user1.ID) + _, _, err = issue.ToggleAssignee(&User{ID: 1}, user1.ID) assert.NoError(t, err) // Check if he got removed |