diff options
| author | zeripath <art27@cantab.net> | 2020-11-10 22:37:11 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-10 22:37:11 +0000 |
| commit | 3fd060eb37085df9b075baf23f3c315b92c1073e (patch) | |
| tree | 58659f779495b8cbfa2cf576d654dbd490fe09c5 /models/issue_reaction.go | |
| parent | 3400928f7ac1fe8326a69a049a5c0b2dc3a3675d (diff) | |
| download | gitea-3fd060eb37085df9b075baf23f3c315b92c1073e.tar.gz gitea-3fd060eb37085df9b075baf23f3c315b92c1073e.zip | |
Include OriginalAuthor in Reaction constraint (#13505)
When migrating repositories with reactions with deleted users, the original
author id may be -1. This means that it is possible to end up attempting
to create multiple reactions with the same [ Type, IssueID, CommentID, UserID,
OriginalAuthorID ] thus breaking the constraints.
On SQLite this appears to cause a deadlock but on other dbs this will
cause the migration to fail.
This PR extends the constraint to include the original author username
in the constraint.
Fix #13271
Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'models/issue_reaction.go')
| -rw-r--r-- | models/issue_reaction.go | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/models/issue_reaction.go b/models/issue_reaction.go index 50b9d6848a..104afce5c1 100644 --- a/models/issue_reaction.go +++ b/models/issue_reaction.go @@ -17,13 +17,13 @@ import ( // Reaction represents a reactions on issues and comments. type Reaction struct { - ID int64 `xorm:"pk autoincr"` - Type string `xorm:"INDEX UNIQUE(s) NOT NULL"` - IssueID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` - CommentID int64 `xorm:"INDEX UNIQUE(s)"` - UserID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` - OriginalAuthorID int64 `xorm:"INDEX UNIQUE(s) NOT NULL DEFAULT(0)"` - OriginalAuthor string + ID int64 `xorm:"pk autoincr"` + Type string `xorm:"INDEX UNIQUE(s) NOT NULL"` + IssueID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` + CommentID int64 `xorm:"INDEX UNIQUE(s)"` + UserID int64 `xorm:"INDEX UNIQUE(s) NOT NULL"` + OriginalAuthorID int64 `xorm:"INDEX UNIQUE(s) NOT NULL DEFAULT(0)"` + OriginalAuthor string `xorm:"INDEX UNIQUE(s)"` User *User `xorm:"-"` CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"` } |