diff options
| author | 6543 <6543@obermui.de> | 2021-01-22 03:56:19 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-21 21:56:19 -0500 |
| commit | a0e424da859a5bf52fe1f08c08a9dcbe3e9d92eb (patch) | |
| tree | f2326a97f31b4816c5e0cba98bf60392898b3728 /models/issue_reaction.go | |
| parent | 0e2e73410e1e222633c007969d384d392d0420a3 (diff) | |
| download | gitea-a0e424da859a5bf52fe1f08c08a9dcbe3e9d92eb.tar.gz gitea-a0e424da859a5bf52fe1f08c08a9dcbe3e9d92eb.zip | |
Enhance Ghost comment mitigation Settings (#14392)
* refactor models.DeleteComment and delete related reactions too
* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser
* nits
* Use time.Duration as other time settings have
* docs
* Resolve Fixme & fix potential deadlock
* Disabled by Default
* Update Config Value Description
* switch args
* Update models/issue_comment.go
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: zeripath <art27@cantab.net>
Diffstat (limited to 'models/issue_reaction.go')
| -rw-r--r-- | models/issue_reaction.go | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/models/issue_reaction.go b/models/issue_reaction.go index 104afce5c1..ad85e5747c 100644 --- a/models/issue_reaction.go +++ b/models/issue_reaction.go @@ -178,11 +178,15 @@ func CreateCommentReaction(doer *User, issue *Issue, comment *Comment, content s }) } -func deleteReaction(e *xorm.Session, opts *ReactionOptions) error { +func deleteReaction(e Engine, opts *ReactionOptions) error { reaction := &Reaction{ - Type: opts.Type, - UserID: opts.Doer.ID, - IssueID: opts.Issue.ID, + Type: opts.Type, + } + if opts.Doer != nil { + reaction.UserID = opts.Doer.ID + } + if opts.Issue != nil { + reaction.IssueID = opts.Issue.ID } if opts.Comment != nil { reaction.CommentID = opts.Comment.ID |