summaryrefslogtreecommitdiffstats
path: root/models/migrations/v115.go
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2020-08-11 21:05:34 +0100
committerGitHub <noreply@github.com>2020-08-11 21:05:34 +0100
commit74bd9691c685942798f2761607731697498ceeae (patch)
tree531d661263b839ccf8aa6af73bfb6710984f0dd9 /models/migrations/v115.go
parentfaa676cc8b4419ac56fbf9d009ea8c6b79834024 (diff)
downloadgitea-74bd9691c685942798f2761607731697498ceeae.tar.gz
gitea-74bd9691c685942798f2761607731697498ceeae.zip
Re-attempt to delete temporary upload if the file is locked by another process (#12447)
Replace all calls to os.Remove/os.RemoveAll by retrying util.Remove/util.RemoveAll and remove circular dependencies from util. Fix #12339 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'models/migrations/v115.go')
-rw-r--r--models/migrations/v115.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/models/migrations/v115.go b/models/migrations/v115.go
index 9b5c70a7ac..fe3b086119 100644
--- a/models/migrations/v115.go
+++ b/models/migrations/v115.go
@@ -15,6 +15,7 @@ import (
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"
+ "code.gitea.io/gitea/modules/util"
"xorm.io/xorm"
)
@@ -110,8 +111,8 @@ func renameExistingUserAvatarName(x *xorm.Engine) error {
log.Info("Deleting %d old avatars ...", deleteCount)
i := 0
for file := range deleteList {
- if err := os.Remove(file); err != nil {
- log.Warn("os.Remove: %v", err)
+ if err := util.Remove(file); err != nil {
+ log.Warn("util.Remove: %v", err)
}
i++
select {