diff options
| author | 6543 <6543@obermui.de> | 2023-07-07 07:31:56 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-07 05:31:56 +0000 |
| commit | 8995046110147ae2c8c98be4e0a8c0b643ccc29c (patch) | |
| tree | 94a3007199687c0a68eee5889af1619f1eebaf61 /models/migrations/v1_13 | |
| parent | b1eb1676aa95d776ff9085002641ad62e040cd93 (diff) | |
| download | gitea-8995046110147ae2c8c98be4e0a8c0b643ccc29c.tar.gz gitea-8995046110147ae2c8c98be4e0a8c0b643ccc29c.zip | |
Less naked returns (#25713)
just a step towards #25655
and some related refactoring
Diffstat (limited to 'models/migrations/v1_13')
| -rw-r--r-- | models/migrations/v1_13/v143.go | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/models/migrations/v1_13/v143.go b/models/migrations/v1_13/v143.go index ad1a8c66a5..885768dff3 100644 --- a/models/migrations/v1_13/v143.go +++ b/models/migrations/v1_13/v143.go @@ -23,25 +23,25 @@ func RecalculateStars(x *xorm.Engine) (err error) { for start := 0; ; start += batchSize { users := make([]User, 0, batchSize) - if err = sess.Limit(batchSize, start).Where("type = ?", 0).Cols("id").Find(&users); err != nil { - return + if err := sess.Limit(batchSize, start).Where("type = ?", 0).Cols("id").Find(&users); err != nil { + return err } if len(users) == 0 { break } - if err = sess.Begin(); err != nil { - return + if err := sess.Begin(); err != nil { + return err } for _, user := range users { - if _, err = sess.Exec("UPDATE `user` SET num_stars=(SELECT COUNT(*) FROM `star` WHERE uid=?) WHERE id=?", user.ID, user.ID); err != nil { - return + if _, err := sess.Exec("UPDATE `user` SET num_stars=(SELECT COUNT(*) FROM `star` WHERE uid=?) WHERE id=?", user.ID, user.ID); err != nil { + return err } } - if err = sess.Commit(); err != nil { - return + if err := sess.Commit(); err != nil { + return err } } |