diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /models/migrations | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'models/migrations')
| -rw-r--r-- | models/migrations/v143.go | 2 | ||||
| -rw-r--r-- | models/migrations/v180.go | 2 | ||||
| -rw-r--r-- | models/migrations/v189.go | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/models/migrations/v143.go b/models/migrations/v143.go index 93237ebfcd..17f3af4497 100644 --- a/models/migrations/v143.go +++ b/models/migrations/v143.go @@ -48,5 +48,5 @@ func recalculateStars(x *xorm.Engine) (err error) { log.Debug("recalculate Stars number for all user finished") - return + return err } diff --git a/models/migrations/v180.go b/models/migrations/v180.go index 492c91f1b9..4468a71078 100644 --- a/models/migrations/v180.go +++ b/models/migrations/v180.go @@ -66,7 +66,7 @@ func deleteMigrationCredentials(x *xorm.Engine) (err error) { return } } - return + return err } func removeCredentials(payload string) (string, error) { diff --git a/models/migrations/v189.go b/models/migrations/v189.go index f136a89b4e..823e27e2ea 100644 --- a/models/migrations/v189.go +++ b/models/migrations/v189.go @@ -81,7 +81,7 @@ func unwrapLDAPSourceCfg(x *xorm.Engine) error { } err := jsonUnmarshalHandleDoubleEncode([]byte(source.Cfg), &wrapped) if err != nil { - return fmt.Errorf("failed to unmarshal %s: %w", string(source.Cfg), err) + return fmt.Errorf("failed to unmarshal %s: %w", source.Cfg, err) } if wrapped.Source != nil && len(wrapped.Source) > 0 { bs, err := json.Marshal(wrapped.Source) |