diff options
| author | 6543 <6543@obermui.de> | 2020-02-28 00:10:27 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-02-27 20:10:27 -0300 |
| commit | e57ac841de1fc93df15ba8bef280077bbb733bf1 (patch) | |
| tree | d81462a68ee6ae6276ae14ef0b3ccc7c0d77ada7 /models/notification.go | |
| parent | 15fbf509d3475cef3f8a7e994b59e4d78fd1c508 (diff) | |
| download | gitea-e57ac841de1fc93df15ba8bef280077bbb733bf1.tar.gz gitea-e57ac841de1fc93df15ba8bef280077bbb733bf1.zip | |
Fix potential bugs (#10513)
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
Diffstat (limited to 'models/notification.go')
| -rw-r--r-- | models/notification.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/models/notification.go b/models/notification.go index c52d6c557a..a7a65c38a4 100644 --- a/models/notification.go +++ b/models/notification.go @@ -396,7 +396,7 @@ func (n *Notification) loadIssue(e Engine) (err error) { func (n *Notification) loadComment(e Engine) (err error) { if n.Comment == nil && n.CommentID > 0 { - n.Comment, err = GetCommentByID(n.CommentID) + n.Comment, err = getCommentByID(e, n.CommentID) if err != nil { return fmt.Errorf("GetCommentByID [%d] for issue ID [%d]: %v", n.CommentID, n.IssueID, err) } |