diff options
| author | Hester Gong <hestergong@gmail.com> | 2023-03-17 18:24:18 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-17 18:24:18 +0800 |
| commit | 8120c0c20c42f46d08356064c7f7fe96fafcfade (patch) | |
| tree | 7a2f408771c1ac144bf81fb4b6a763cc9c8ad091 /models/project | |
| parent | 6aca9287a216b4d41c48469b1bbf6b61a438805a (diff) | |
| download | gitea-8120c0c20c42f46d08356064c7f7fe96fafcfade.tar.gz gitea-8120c0c20c42f46d08356064c7f7fe96fafcfade.zip | |
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (#23513)
Close #23466
Right now on pull request "files Changed" tab, if a file is viewed, when
the comments' links are visited, the comment will not be shown as the
file is folded after viewed. This PR is to improve the behavior, to make
the comment seen even the related file is folded, like on github.
And right now scroll position will be remembered and hence it won’t
scroll to hashed comment after refreshing, this PR also adjust the
scroll position remembering behavior: When there is hash comment in url,
do not remember the scroll position.
Before:
https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov
After:
https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov
Update - long comment's behavior after using `scrollTop ` (Comment div
scroll to the position which is 30px below the diff header, or 30px
below top on conversation tab):
https://user-images.githubusercontent.com/17645053/225614460-0602c1a6-229c-41f4-84d2-334e78251486.mov
Diffstat (limited to 'models/project')
0 files changed, 0 insertions, 0 deletions