diff options
| author | Harshit Bansal <harshitbansal2015@gmail.com> | 2019-01-01 04:30:54 +0530 |
|---|---|---|
| committer | techknowlogick <hello@techknowlogick.com> | 2018-12-31 18:00:54 -0500 |
| commit | 63bd1b92037c5deb1bb13b0753855a689b9450bc (patch) | |
| tree | c5377c5d3138ad5f32470bf7e389dba39faf0c50 /models/release.go | |
| parent | b46c2795877c721f738472073ae5b03ecceb6c0a (diff) | |
| download | gitea-63bd1b92037c5deb1bb13b0753855a689b9450bc.tar.gz gitea-63bd1b92037c5deb1bb13b0753855a689b9450bc.zip | |
mirror: Delete tags in mirror which are removed for original repo. (#5609)
This bug was being caused by an error in the logic in `release.go`.
Credit to @yasuokav for tracing the root of the issue.
Fixes: #5192.
Diffstat (limited to 'models/release.go')
| -rw-r--r-- | models/release.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/models/release.go b/models/release.go index c18e152293..c1c8b933d0 100644 --- a/models/release.go +++ b/models/release.go @@ -479,10 +479,10 @@ func SyncReleasesWithTags(repo *Repository, gitRepo *git.Repository) error { continue } commitID, err := gitRepo.GetTagCommitID(rel.TagName) - if err != nil { + if err != nil && !git.IsErrNotExist(err) { return fmt.Errorf("GetTagCommitID: %v", err) } - if !gitRepo.IsTagExist(rel.TagName) || commitID != rel.Sha1 { + if git.IsErrNotExist(err) || commitID != rel.Sha1 { if err := pushUpdateDeleteTag(repo, gitRepo, rel.TagName); err != nil { return fmt.Errorf("pushUpdateDeleteTag: %v", err) } |