diff options
| author | oliverpool <3864879+oliverpool@users.noreply.github.com> | 2023-04-18 21:11:17 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-18 21:11:17 +0200 |
| commit | bb2783860b8db033f9dcbd223a6c8b5a5c1044ac (patch) | |
| tree | 3107ddfb1418ca3e2ab07041c75fe61640d18955 /models/repo | |
| parent | 75b9845420bb5686fc212272a4d9a07543eaced7 (diff) | |
| download | gitea-bb2783860b8db033f9dcbd223a6c8b5a5c1044ac.tar.gz gitea-bb2783860b8db033f9dcbd223a6c8b5a5c1044ac.zip | |
fix calReleaseNumCommitsBehind (#24148)
`repoCtx.CommitsCount` is not reliably the commit count of the default
branch (Repository.GetCommitsCount depends on what is currently
displayed).
For instance on the releases page the commit count is correct:
https://codeberg.org/Codeberg/pages-server/releases
However it is not on the single page:
https://codeberg.org/Codeberg/pages-server/releases/tag/v4.6.2
This PR fixes this by removing a "fast branch" which was using this
field (I think this field should be removed, since it is a bit
unpredictable - but this would mean a larger refactoring PR).
_contributed in the context of @forgejo_
---------
Co-authored-by: Giteabot <teabot@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'models/repo')
| -rw-r--r-- | models/repo/repo_list_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/models/repo/repo_list_test.go b/models/repo/repo_list_test.go index d87d70c189..573281ea0b 100644 --- a/models/repo/repo_list_test.go +++ b/models/repo/repo_list_test.go @@ -235,12 +235,12 @@ func TestSearchRepository(t *testing.T) { { name: "AllPublic/PublicRepositoriesOfUserIncludingCollaborative", opts: &repo_model.SearchRepoOptions{ListOptions: db.ListOptions{Page: 1, PageSize: 10}, OwnerID: 15, AllPublic: true, Template: util.OptionalBoolFalse}, - count: 29, + count: 30, }, { name: "AllPublic/PublicAndPrivateRepositoriesOfUserIncludingCollaborative", opts: &repo_model.SearchRepoOptions{ListOptions: db.ListOptions{Page: 1, PageSize: 10}, OwnerID: 15, Private: true, AllPublic: true, AllLimited: true, Template: util.OptionalBoolFalse}, - count: 34, + count: 35, }, { name: "AllPublic/PublicAndPrivateRepositoriesOfUserIncludingCollaborativeByName", @@ -255,7 +255,7 @@ func TestSearchRepository(t *testing.T) { { name: "AllPublic/PublicRepositoriesOfOrganization", opts: &repo_model.SearchRepoOptions{ListOptions: db.ListOptions{Page: 1, PageSize: 10}, OwnerID: 17, AllPublic: true, Collaborate: util.OptionalBoolFalse, Template: util.OptionalBoolFalse}, - count: 29, + count: 30, }, { name: "AllTemplates", |