diff options
| author | Cirno the Strongest <1447794+CirnoT@users.noreply.github.com> | 2020-06-13 13:35:59 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-06-13 12:35:59 +0100 |
| commit | 0159851cc3fa80e4df4908a5e760afa20452f712 (patch) | |
| tree | 8f920c6cb3744939c5c9b9e633749cc5a54ab0ab /models/user.go | |
| parent | 2447ffc74a6e3ab57d98a52de0a7398cadb71e08 (diff) | |
| download | gitea-0159851cc3fa80e4df4908a5e760afa20452f712.tar.gz gitea-0159851cc3fa80e4df4908a5e760afa20452f712.zip | |
Rework api/user/repos for pagination (#11827)
* Add count to `GetUserRepositories` so that pagination can be supported for `/user/{username}/repos`
* Rework ListMyRepos to use models.SearchRepository
ListMyRepos was an odd one. It first fetched all user repositories and then tried to supplement them with accessible map. The end result was that:
* Limit for pagination did not work because accessible repos would always be appended
* The amount of pages was incorrect if one were to calculate it
* When paginating, all accessible repos would be shown on every page
Hopefully it should now work properly. Fixes #11800 and does not require any change on Drone-side as it can properly interpret and act on Link header which we now set.
Co-authored-by: Lauris BH <lauris@nix.lv>
Diffstat (limited to 'models/user.go')
| -rw-r--r-- | models/user.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/models/user.go b/models/user.go index 0ecb1b9a48..8056e30cea 100644 --- a/models/user.go +++ b/models/user.go @@ -646,7 +646,7 @@ func (u *User) GetOrganizationCount() (int64, error) { // GetRepositories returns repositories that user owns, including private repositories. func (u *User) GetRepositories(listOpts ListOptions) (err error) { - u.Repos, err = GetUserRepositories(&SearchRepoOptions{Actor: u, Private: true, ListOptions: listOpts}) + u.Repos, _, err = GetUserRepositories(&SearchRepoOptions{Actor: u, Private: true, ListOptions: listOpts}) return err } |