diff options
| author | Unknwon <joe2010xtmf@163.com> | 2014-10-09 19:01:22 -0400 |
|---|---|---|
| committer | Unknwon <joe2010xtmf@163.com> | 2014-10-09 19:01:22 -0400 |
| commit | 79262173a6e0a5734ebfc1565e45353677008302 (patch) | |
| tree | 279574f1398259d1a875dacd0817e77c9117ccc0 /models/webhook.go | |
| parent | 7b03b1df0efab201b48001200b17ed3390fa83da (diff) | |
| download | gitea-79262173a6e0a5734ebfc1565e45353677008302.tar.gz gitea-79262173a6e0a5734ebfc1565e45353677008302.zip | |
Webhook delivery locking & Hide repo for org members if they don't have access
Diffstat (limited to 'models/webhook.go')
| -rw-r--r-- | models/webhook.go | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/models/webhook.go b/models/webhook.go index 9508c98a5e..ac0c240977 100644 --- a/models/webhook.go +++ b/models/webhook.go @@ -235,8 +235,22 @@ func UpdateHookTask(t *HookTask) error { return err } +var ( + // Prevent duplicate deliveries. + // This happens with massive hook tasks cannot finish delivering + // before next shooting starts. + isShooting = false +) + // DeliverHooks checks and delivers undelivered hooks. +// FIXME: maybe can use goroutine to shoot a number of them at same time? func DeliverHooks() { + if isShooting { + return + } + isShooting = true + defer func() { isShooting = false }() + tasks := make([]*HookTask, 0, 10) timeout := time.Duration(setting.WebhookDeliverTimeout) * time.Second x.Where("is_delivered=?", false).Iterate(new(HookTask), @@ -255,7 +269,7 @@ func DeliverHooks() { t.IsDelivered = true - // TODO: record response. + // FIXME: record response. switch t.Type { case GOGS: { |