Remove local clones & make hooks run on merge/edit/upload (#6672)

* Add options to git.Clone to make it more capable

* Begin the process of removing the local copy and tidy up

* Remove Wiki LocalCopy Checkouts

* Remove the last LocalRepo helpers

* Remove WithTemporaryFile

* Enable push-hooks for these routes

* Ensure tests cope with hooks

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove Repository.LocalCopyPath()

* Move temporary repo to use the standard temporary path

* Fix the tests

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Remove LocalWikiPath

* Fix missing remove

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Use AppURL for Oauth user link (#6894)

* Use AppURL for Oauth user link

Fix #6843

* Update oauth.go

* Update oauth.go

* internal/ssh: ignore env command totally (#6825)

* ssh: ignore env command totally

* Remove commented code 

Needed fix described in issue #6889

* Escape the commit message on issues update and title in telegram hook (#6901)

* update sdk to latest (#6903)

* improve description of branch protection (fix #6886) (#6906)

The branch protection description text were not quite accurate.

* Fix logging documentation (#6904)

* ENABLE_MACARON_REDIRECT should be REDIRECT_MACARON_LOG

* Allow DISABLE_ROUTER_LOG to be set in the [log] section

* [skip ci] Updated translations via Crowdin

* Move sdk structs to modules/structs (#6905)

* move sdk structs to moduels/structs

* fix tests

* fix fmt

* fix swagger

* fix vendor

1 files changed, 32 insertions, 17 deletions

diff --git a/models/wiki_test.go b/models/wiki_test.go
index 5280b3ea01..991a3d95b9 100644
--- a/models/wiki_test.go
+++ b/models/wiki_test.go
@@ -5,13 +5,12 @@
 package models
 
 import (
-	"path"
 	"path/filepath"
 	"testing"
 
+	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/setting"
 
-	"github.com/Unknwon/com"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -145,13 +144,6 @@ func TestRepository_InitWiki(t *testing.T) {
 	assert.True(t, repo2.HasWiki())
 }
 
-func TestRepository_LocalWikiPath(t *testing.T) {
-	PrepareTestEnv(t)
-	repo := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
-	expected := filepath.Join(setting.AppDataPath, setting.Repository.Local.LocalWikiPath, "1")
-	assert.Equal(t, expected, repo.LocalWikiPath())
-}
-
 func TestRepository_AddWikiPage(t *testing.T) {
 	assert.NoError(t, PrepareTestDatabase())
 	const wikiContent = "This is the wiki content"
@@ -166,8 +158,15 @@ func TestRepository_AddWikiPage(t *testing.T) {
 		t.Run("test wiki exist: "+wikiName, func(t *testing.T) {
 			t.Parallel()
 			assert.NoError(t, repo.AddWikiPage(doer, wikiName, wikiContent, commitMsg))
-			expectedPath := path.Join(repo.LocalWikiPath(), WikiNameToFilename(wikiName))
-			assert.True(t, com.IsExist(expectedPath))
+			// Now need to show that the page has been added:
+			gitRepo, err := git.OpenRepository(repo.WikiPath())
+			assert.NoError(t, err)
+			masterTree, err := gitRepo.GetTree("master")
+			assert.NoError(t, err)
+			wikiPath := WikiNameToFilename(wikiName)
+			entry, err := masterTree.GetTreeEntryByPath(wikiPath)
+			assert.NoError(t, err)
+			assert.Equal(t, wikiPath, entry.Name(), "%s not addded correctly", wikiName)
 		})
 	}
 
@@ -200,11 +199,20 @@ func TestRepository_EditWikiPage(t *testing.T) {
 	} {
 		PrepareTestEnv(t)
 		assert.NoError(t, repo.EditWikiPage(doer, "Home", newWikiName, newWikiContent, commitMsg))
-		newPath := path.Join(repo.LocalWikiPath(), WikiNameToFilename(newWikiName))
-		assert.True(t, com.IsExist(newPath))
+
+		// Now need to show that the page has been added:
+		gitRepo, err := git.OpenRepository(repo.WikiPath())
+		assert.NoError(t, err)
+		masterTree, err := gitRepo.GetTree("master")
+		assert.NoError(t, err)
+		wikiPath := WikiNameToFilename(newWikiName)
+		entry, err := masterTree.GetTreeEntryByPath(wikiPath)
+		assert.NoError(t, err)
+		assert.Equal(t, wikiPath, entry.Name(), "%s not editted correctly", newWikiName)
+
 		if newWikiName != "Home" {
-			oldPath := path.Join(repo.LocalWikiPath(), "Home.md")
-			assert.False(t, com.IsExist(oldPath))
+			_, err := masterTree.GetTreeEntryByPath("Home.md")
+			assert.Error(t, err)
 		}
 	}
 }
@@ -214,6 +222,13 @@ func TestRepository_DeleteWikiPage(t *testing.T) {
 	repo := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
 	doer := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
 	assert.NoError(t, repo.DeleteWikiPage(doer, "Home"))
-	wikiPath := path.Join(repo.LocalWikiPath(), "Home.md")
-	assert.False(t, com.IsExist(wikiPath))
+
+	// Now need to show that the page has been added:
+	gitRepo, err := git.OpenRepository(repo.WikiPath())
+	assert.NoError(t, err)
+	masterTree, err := gitRepo.GetTree("master")
+	assert.NoError(t, err)
+	wikiPath := WikiNameToFilename("Home")
+	_, err = masterTree.GetTreeEntryByPath(wikiPath)
+	assert.Error(t, err)
 }