diff options
| author | Ondřej Čertík <ondrej@certik.us> | 2022-05-26 03:19:24 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-26 10:19:24 +0100 |
| commit | 8720f876c74e4ab63828a8ecd8b5f5465aef58fa (patch) | |
| tree | fbb4a5b7e8d4d197edd6bff45bff616e242bca97 /models | |
| parent | 9574626a23569b09230ad6fe2b99357acab25d1a (diff) | |
| download | gitea-8720f876c74e4ab63828a8ecd8b5f5465aef58fa.tar.gz gitea-8720f876c74e4ab63828a8ecd8b5f5465aef58fa.zip | |
Make WIP prefixes case insensitive, e.g. allow `Draft` as a WIP prefix (#19780)
The issue was that only the actual title was converted to uppercase, but
not the prefix as specified in `WORK_IN_PROGRESS_PREFIXES`. As a result,
the following did not work:
WORK_IN_PROGRESS_PREFIXES=Draft:,[Draft],WIP:,[WIP]
One possible workaround was:
WORK_IN_PROGRESS_PREFIXES=DRAFT:,[DRAFT],WIP:,[WIP]
Then indeed one could use `Draft` (as well as `DRAFT`) in the title.
However, the link `Start the title with DRAFT: to prevent the pull request
from being merged accidentally.` showed the suggestion in uppercase; so
it is not possible to show it as `Draft`. This PR fixes it, and allows
to use `Draft` in `WORK_IN_PROGRESS_PREFIXES`.
Fixes #19779.
Co-authored-by: zeripath <art27@cantab.net>
Diffstat (limited to 'models')
| -rw-r--r-- | models/pull.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/models/pull.go b/models/pull.go index bb5bb11812..df96e2dc74 100644 --- a/models/pull.go +++ b/models/pull.go @@ -588,7 +588,7 @@ func (pr *PullRequest) IsWorkInProgress() bool { // HasWorkInProgressPrefix determines if the given PR title has a Work In Progress prefix func HasWorkInProgressPrefix(title string) bool { for _, prefix := range setting.Repository.PullRequest.WorkInProgressPrefixes { - if strings.HasPrefix(strings.ToUpper(title), prefix) { + if strings.HasPrefix(strings.ToUpper(title), strings.ToUpper(prefix)) { return true } } @@ -609,7 +609,7 @@ func (pr *PullRequest) GetWorkInProgressPrefix() string { } for _, prefix := range setting.Repository.PullRequest.WorkInProgressPrefixes { - if strings.HasPrefix(strings.ToUpper(pr.Issue.Title), prefix) { + if strings.HasPrefix(strings.ToUpper(pr.Issue.Title), strings.ToUpper(prefix)) { return pr.Issue.Title[0:len(prefix)] } } |