Use ioutil.TmpDir for new created temp directory (#9368)

* Use os.TmpDir for new created temp directory

* fix error message

2 files changed, 6 insertions, 9 deletions

diff --git a/models/repo.go b/models/repo.go
index c7eee3c1ec..02cb3b9128 100644
--- a/models/repo.go
+++ b/models/repo.go
@@ -1198,13 +1198,11 @@ func initRepository(e Engine, repoPath string, u *User, repo *Repository, opts C
 		return err
 	}
 
-	tmpDir := filepath.Join(os.TempDir(), "gitea-"+repo.Name+"-"+com.ToStr(time.Now().Nanosecond()))
-
 	// Initialize repository according to user's choice.
 	if opts.AutoInit {
-
-		if err := os.MkdirAll(tmpDir, os.ModePerm); err != nil {
-			return fmt.Errorf("Failed to create dir %s: %v", tmpDir, err)
+		tmpDir, err := ioutil.TempDir(os.TempDir(), "gitea-"+repo.Name)
+		if err != nil {
+			return fmt.Errorf("Failed to create temp dir for repository %s: %v", repo.repoPath(e), err)
 		}
 
 		defer os.RemoveAll(tmpDir)
diff --git a/models/repo_generate.go b/models/repo_generate.go
index 6dd8540d9e..98ef0ea000 100644
--- a/models/repo_generate.go
+++ b/models/repo_generate.go
@@ -179,10 +179,9 @@ func generateRepoCommit(e Engine, repo, templateRepo, generateRepo *Repository,
 
 // generateRepository initializes repository from template
 func generateRepository(e Engine, repo, templateRepo, generateRepo *Repository) (err error) {
-	tmpDir := filepath.Join(os.TempDir(), "gitea-"+repo.Name+"-"+com.ToStr(time.Now().Nanosecond()))
-
-	if err := os.MkdirAll(tmpDir, os.ModePerm); err != nil {
-		return fmt.Errorf("Failed to create dir %s: %v", tmpDir, err)
+	tmpDir, err := ioutil.TempDir(os.TempDir(), "gitea-"+repo.Name)
+	if err != nil {
+		return fmt.Errorf("Failed to create temp dir for repository %s: %v", repo.repoPath(e), err)
 	}
 
 	defer func() {