diff options
| author | Gusted <williamzijl7@hotmail.com> | 2021-11-18 01:33:06 +0000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-18 09:33:06 +0800 |
| commit | c98dd7a3e0a08b1e890d6030dd51aae9dd45aaf9 (patch) | |
| tree | e50b4bf9fc94e26d26d1f9709f4e8275eed60fc1 /models | |
| parent | b01f6c1a8c9f358c297e0d1f4ee8696c9e25d5b2 (diff) | |
| download | gitea-c98dd7a3e0a08b1e890d6030dd51aae9dd45aaf9.tar.gz gitea-c98dd7a3e0a08b1e890d6030dd51aae9dd45aaf9.zip | |
Remove unnecessary variable assignments (#17695)
* Remove unnecessary variable assignments
As title
* enable ineffassign
Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'models')
| -rw-r--r-- | models/issue_assignees_test.go | 2 | ||||
| -rw-r--r-- | models/topic_test.go | 3 | ||||
| -rw-r--r-- | models/user_email_test.go | 4 |
3 files changed, 4 insertions, 5 deletions
diff --git a/models/issue_assignees_test.go b/models/issue_assignees_test.go index d1ce000de6..b604f13bd5 100644 --- a/models/issue_assignees_test.go +++ b/models/issue_assignees_test.go @@ -72,7 +72,7 @@ func TestMakeIDsFromAPIAssigneesToAdd(t *testing.T) { assert.NoError(t, err) assert.Equal(t, []int64{}, IDs) - IDs, err = MakeIDsFromAPIAssigneesToAdd("", []string{"none_existing_user"}) + _, err = MakeIDsFromAPIAssigneesToAdd("", []string{"none_existing_user"}) assert.Error(t, err) IDs, err = MakeIDsFromAPIAssigneesToAdd("user1", []string{"user1"}) diff --git a/models/topic_test.go b/models/topic_test.go index a38ed64940..0219bdded5 100644 --- a/models/topic_test.go +++ b/models/topic_test.go @@ -16,7 +16,6 @@ import ( func TestAddTopic(t *testing.T) { totalNrOfTopics := 6 repo1NrOfTopics := 3 - repo2NrOfTopics := 2 assert.NoError(t, unittest.PrepareTestDatabase()) @@ -38,7 +37,7 @@ func TestAddTopic(t *testing.T) { assert.Len(t, topics, repo1NrOfTopics) assert.NoError(t, SaveTopics(2, "golang")) - repo2NrOfTopics = 1 + repo2NrOfTopics := 1 topics, _, err = FindTopics(&FindTopicOptions{}) assert.NoError(t, err) assert.Len(t, topics, totalNrOfTopics) diff --git a/models/user_email_test.go b/models/user_email_test.go index bde0778b64..bed6a18867 100644 --- a/models/user_email_test.go +++ b/models/user_email_test.go @@ -111,14 +111,14 @@ func TestListEmails(t *testing.T) { // Must find only primary addresses (i.e. from the `user` table) opts = &SearchEmailOptions{IsPrimary: util.OptionalBoolTrue} - emails, count, err = SearchEmails(opts) + emails, _, err = SearchEmails(opts) assert.NoError(t, err) assert.True(t, contains(func(s *SearchEmailResult) bool { return s.IsPrimary })) assert.False(t, contains(func(s *SearchEmailResult) bool { return !s.IsPrimary })) // Must find only inactive addresses (i.e. not validated) opts = &SearchEmailOptions{IsActivated: util.OptionalBoolFalse} - emails, count, err = SearchEmails(opts) + emails, _, err = SearchEmails(opts) assert.NoError(t, err) assert.True(t, contains(func(s *SearchEmailResult) bool { return !s.IsActivated })) assert.False(t, contains(func(s *SearchEmailResult) bool { return s.IsActivated })) |